From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbbCYFZM (ORCPT ); Wed, 25 Mar 2015 01:25:12 -0400 Received: from ozlabs.org ([103.22.144.67]:44535 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbbCYFZL (ORCPT ); Wed, 25 Mar 2015 01:25:11 -0400 In-Reply-To: To: Jan Stancek , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: linux-kernel@vger.kernel.org, paulus@samba.org, anton@samba.org, tj@kernel.org, cl@linux.com, jolsa@redhat.com, jstancek@redhat.com, joel@jms.id.au Subject: Re: powerpc/perf: add missing put_cpu_var in power_pmu_event_init Message-Id: <20150325052509.C995F1400F1@ozlabs.org> Date: Wed, 25 Mar 2015 16:25:09 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-24-03 at 12:33:22 UTC, Jan Stancek wrote: > One path in power_pmu_event_init() calls get_cpu_var(), but is > missing matching call to put_cpu_var(), which causes preemption > imbalance and crash in user-space: > > Page fault in user mode with in_atomic() = 1 mm = c000001fefa5a280 > NIP = 3fff9bf2cae0 MSR = 900000014280f032 > Oops: Weird page fault, sig: 11 [#23] Thanks. But I don't see this. I guess you have CONFIG_PREEMPT enabled? cheers