From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752563AbbCYGao (ORCPT ); Wed, 25 Mar 2015 02:30:44 -0400 Received: from mail-bn1on0145.outbound.protection.outlook.com ([157.56.110.145]:14112 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750865AbbCYGam (ORCPT ); Wed, 25 Mar 2015 02:30:42 -0400 Date: Wed, 25 Mar 2015 14:29:18 +0800 From: Peter Chen To: Julia Lawall CC: kbuild test robot , , , , Subject: Re: [PATCH] usb: chipidea: usbmisc_imx: fix returnvar.cocci warnings Message-ID: <20150325062916.GB8235@shlinux2> References: <201503250705.ZLF1deME%fengguang.wu@intel.com> <20150324234408.GA120171@athens> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=peter.chen@freescale.com; linuxfoundation.org; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(339900001)(199003)(24454002)(189002)(51704005)(41574002)(87936001)(62966003)(15975445007)(46406003)(47776003)(33716001)(92566002)(77156002)(50466002)(23726002)(2950100001)(77096005)(50986999)(105606002)(97756001)(54356999)(76176999)(86362001)(83506001)(85426001)(19580405001)(19580395003)(110136001)(46102003)(33656002)(106466001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0639;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0639; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:DM2PR0301MB0639;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0639; X-Forefront-PRVS: 052670E5A4 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2015 06:30:39.0908 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0639 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 07:23:52AM +0100, Julia Lawall wrote: > Please take a look. > It is strange why I did not receive it. The patch is ok. Signed-off-by: Peter Chen > thanks, > julia > > On Wed, 25 Mar 2015, kbuild test robot wrote: > > > TO: Peter Chen > > CC: "Greg Kroah-Hartman" > > CC: linux-usb@vger.kernel.org > > CC: linux-kernel@vger.kernel.org > > > > drivers/usb/chipidea/usbmisc_imx.c:277:5-8: Unneeded variable: "ret". Return "0" on line 297 > > > > > > Removes unneeded variable used to store return value. > > > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > > > CC: Peter Chen > > Signed-off-by: Fengguang Wu > > --- > > > > Please take the patch only if it's a positive warning. Thanks! > > > > usbmisc_imx.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > --- a/drivers/usb/chipidea/usbmisc_imx.c > > +++ b/drivers/usb/chipidea/usbmisc_imx.c > > @@ -274,7 +274,6 @@ static int usbmisc_imx6sx_init(struct im > > unsigned long flags; > > struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev); > > u32 val; > > - int ret = 0; > > > > usbmisc_imx6q_init(data); > > > > @@ -294,7 +293,7 @@ static int usbmisc_imx6sx_init(struct im > > spin_unlock_irqrestore(&usbmisc->lock, flags); > > } > > > > - return ret; > > + return 0; > > } > > > > static int usbmisc_vf610_init(struct imx_usbmisc_data *data) > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Peter Chen