From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbbCYI6y (ORCPT ); Wed, 25 Mar 2015 04:58:54 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35864 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbbCYI6v (ORCPT ); Wed, 25 Mar 2015 04:58:51 -0400 Date: Wed, 25 Mar 2015 09:58:40 +0100 From: Ingo Molnar To: carlossilveirajr@gmail.com Cc: mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix braces to GNU style Message-ID: <20150325085840.GA32673@gmail.com> References: <1427248767-5141-1-git-send-email-carlossilveirajr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427248767-5141-1-git-send-email-carlossilveirajr@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * carlossilveirajr@gmail.com wrote: > From: Carlos Roberto Silveira Junior > > --- > kernel/sched/fair.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 7ce18f3..834aa55 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -296,13 +296,12 @@ static inline void list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq) > * reduces this to two cases. > */ > if (cfs_rq->tg->parent && > - cfs_rq->tg->parent->cfs_rq[cpu_of(rq_of(cfs_rq))]->on_list) { > + cfs_rq->tg->parent->cfs_rq[cpu_of(rq_of(cfs_rq))]->on_list) > list_add_rcu(&cfs_rq->leaf_cfs_rq_list, > &rq_of(cfs_rq)->leaf_cfs_rq_list); > - } else { > + else > list_add_tail_rcu(&cfs_rq->leaf_cfs_rq_list, > &rq_of(cfs_rq)->leaf_cfs_rq_list); > - } > > cfs_rq->on_list = 1; > /* We should have no load, but we need to update last_decay. */ > @@ -505,9 +504,9 @@ static void __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se) > * We dont care about collisions. Nodes with > * the same key stay together. > */ > - if (entity_before(se, entry)) { > + if (entity_before(se, entry)) > link = &parent->rb_left; > - } else { > + else { > link = &parent->rb_right; > leftmost = 0; > } But in the kernel we are following the Linux kernel style. Thanks, Ingo