From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbbCYJMZ (ORCPT ); Wed, 25 Mar 2015 05:12:25 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:50586 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbbCYJMS (ORCPT ); Wed, 25 Mar 2015 05:12:18 -0400 Date: Wed, 25 Mar 2015 10:12:08 +0100 From: Ralf Baechle To: Valentin Rothberg Cc: david.daney@cavium.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, lrosenboim@caviumnetworks.com, aleksey.makarov@auriga.com Subject: Re: Enable little endian kernel: misspelled Kconfig item Message-ID: <20150325091208.GG1385@linux-mips.org> References: <20150325075720.GA18552@station.rsr.lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150325075720.GA18552@station.rsr.lip6.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 08:57:20AM +0100, Valentin Rothberg wrote: > Hi David, > > your commit 9861908f081f ("MIPS: OCTEON: Enable little endian kernel.") > adds the following conditional select to arch/mips/Kconfig: > > + select SYS_SUPPORTS_HOTPLUG_CPU if CONFIG_CPU_BIG_ENDIAN > > The problem is the 'CONFIG_' prefix for 'CPU_BIG_ENDIAN'. The item is > always off since the prefix does not work as we are in a Kconfig file. > Hence, the if-statement never evaluates to true. > > It can be fixed by simply removing the 'CONFIG_' prefix. > > I detected this commit with ./scripts/checkkconfigsymbols.py. Commit > b1a3f243485f ("checkkconfigsymbols.py: make it Git aware") added support > to check (and compare) undefined Kconfig symbols in Git commits. I've folded in a fix for the issue. Ralf