From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Andrey Ryabinin <a.ryabinin@samsung.com>
Cc: Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jespern@axis.com>,
linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
Yury Gribov <y.gribov@samsung.com>
Subject: Re: [PATCH] cris: fix integer overflow in ELF_ET_DYN_BASE
Date: Wed, 25 Mar 2015 11:37:02 +0100 [thread overview]
Message-ID: <20150325103702.GF26081@axis.com> (raw)
In-Reply-To: <1427211084-24839-2-git-send-email-a.ryabinin@samsung.com>
On Tue, Mar 24, 2015 at 06:31:23PM +0300, Andrey Ryabinin wrote:
> Almost all arches define ELF_ET_DYN_BASE as 2/3 of TASK_SIZE.
> Though it seems that some architectures do this in a wrong way.
> The problem is that 2*TASK_SIZE may overflow 32-bits so
> the real ELF_ET_DYN_BASE becomes wrong.
> Fix this overflow by dividing TASK_SIZE prior to multiplying:
> (TASK_SIZE / 3 * 2)
Good catch, thanks, added to the CRIS-tree.
> Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2015-03-25 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 15:31 [PATCH] avr32: fix integer overflow in ELF_ET_DYN_BASE Andrey Ryabinin
2015-03-24 15:31 ` [PATCH] cris: " Andrey Ryabinin
2015-03-25 10:37 ` Jesper Nilsson [this message]
2015-03-24 15:31 ` [PATCH] x86, UML: " Andrey Ryabinin
2015-03-25 6:29 ` [PATCH] avr32: " Hans-Christian Egtvedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325103702.GF26081@axis.com \
--to=jesper.nilsson@axis.com \
--cc=a.ryabinin@samsung.com \
--cc=jespern@axis.com \
--cc=keescook@chromium.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=starvik@axis.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox