From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbbCYMPV (ORCPT ); Wed, 25 Mar 2015 08:15:21 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:34611 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbbCYMPT (ORCPT ); Wed, 25 Mar 2015 08:15:19 -0400 Date: Wed, 25 Mar 2015 13:15:14 +0100 From: Ingo Molnar To: "K. Y. Srinivasan" Cc: x86@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, tglx@linutronix.de, hpa@zytor.com Subject: Re: [PATCH V2 1/1] X86: hyperv: Enable MSR based APIC access Message-ID: <20150325121514.GB2542@gmail.com> References: <1426714696-8557-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426714696-8557-1-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * K. Y. Srinivasan wrote: > If the hypervisor supports MSR based access to the APIC registers > (EOI, TPR and ICR), implement the MSR based access. > > Signed-off-by: K. Y. Srinivasan > --- > Changes from V1: Addressed comments from Ingo Molnar You didn't address my primary feedback: > > So since we are trying to explain things, wouldn't this comment be > > more informative if it explained why we are trying to use the > > x2APIC facilities of Hyper-V? > > > > I.e. what are the benefits of using the x2apic API towards the > > hypervisor? please explain the purpose, context and benefits, not just what the patch does - even if the comment from your first patch is now gone. Thanks, Ingo