From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbbCYNbY (ORCPT ); Wed, 25 Mar 2015 09:31:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48477 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbbCYNbX (ORCPT ); Wed, 25 Mar 2015 09:31:23 -0400 Date: Wed, 25 Mar 2015 13:37:56 +0100 From: Greg Kroah-Hartman To: James Hogan Cc: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] MIPS: Add CDMM bus support Message-ID: <20150325123756.GA2200@kroah.com> References: <1422877510-29247-1-git-send-email-james.hogan@imgtec.com> <1422877510-29247-3-git-send-email-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422877510-29247-3-git-send-email-james.hogan@imgtec.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 02, 2015 at 11:45:09AM +0000, James Hogan wrote: > +struct bus_type mips_cdmm_bustype = { > + .name = "cdmm", > + .dev_attrs = mips_cdmm_dev_attrs, .dev_attrs is going away "soon", please use dev_groups instead here. thanks, greg k-h