From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933229AbbCYPJE (ORCPT ); Wed, 25 Mar 2015 11:09:04 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:34115 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932213AbbCYPH6 (ORCPT ); Wed, 25 Mar 2015 11:07:58 -0400 Date: Thu, 26 Mar 2015 00:07:50 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 2/2] zsmalloc: micro-optimize zs_object_copy() Message-ID: <20150325150750.GD3814@blaptop> References: <1427210687-6634-1-git-send-email-sergey.senozhatsky@gmail.com> <1427210687-6634-3-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427210687-6634-3-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 12:24:47AM +0900, Sergey Senozhatsky wrote: > A micro-optimization. Avoid additional branching and reduce > (a bit) registry pressure (f.e. s_off += size; d_off += size; > may be calculated twise: first for >= PAGE_SIZE check and later > for offset update in "else" clause). > > /scripts/bloat-o-meter shows some improvement > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10) > function old new delta > zs_object_copy 550 540 -10 > > Signed-off-by: Sergey Senozhatsky Acked-by: Minchan Kim Thanks. -- Kind regards, Minchan Kim