From: Djalal Harouni <tixxdz@opendz.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Paul Osmialowski <p.osmialowsk@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Mack <daniel@zonque.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Lukasz Skalski <l.skalski@samsung.com>
Subject: Re: [RFC PATCH] kdbus: move all kdbus headers to include/linux/kdbus
Date: Wed, 25 Mar 2015 17:11:13 +0100 [thread overview]
Message-ID: <20150325161113.GA5177@dztty> (raw)
In-Reply-To: <CANq1E4QmJphrB86ZarcreD9OA8oOWJgYogqV1pCRxj-M1e6GNA@mail.gmail.com>
On Wed, Mar 25, 2015 at 04:45:33PM +0100, David Herrmann wrote:
> Hi
>
> On Wed, Mar 25, 2015 at 4:37 PM, Paul Osmialowski
> <p.osmialowsk@samsung.com> wrote:
> > These headers are required to implement LSM hooks for kdbus
> > and possibly other things that might deal with kdbus.
> >
> > Signed-off-by: Paul Osmialowski <p.osmialowsk@samsung.com>
> > ---
> > include/linux/kdbus/bus.h | 101 +++++++++++++++
> > include/linux/kdbus/connection.h | 257 +++++++++++++++++++++++++++++++++++++++
> > include/linux/kdbus/domain.h | 77 ++++++++++++
> > include/linux/kdbus/endpoint.h | 67 ++++++++++
> > include/linux/kdbus/fs.h | 28 +++++
> > include/linux/kdbus/handle.h | 85 +++++++++++++
> > include/linux/kdbus/item.h | 64 ++++++++++
> > include/linux/kdbus/limits.h | 64 ++++++++++
> > include/linux/kdbus/match.h | 35 ++++++
> > include/linux/kdbus/message.h | 133 ++++++++++++++++++++
> > include/linux/kdbus/metadata.h | 57 +++++++++
> > include/linux/kdbus/names.h | 74 +++++++++++
> > include/linux/kdbus/node.h | 84 +++++++++++++
> > include/linux/kdbus/notify.h | 30 +++++
> > include/linux/kdbus/policy.h | 51 ++++++++
> > include/linux/kdbus/pool.h | 46 +++++++
> > include/linux/kdbus/queue.h | 92 ++++++++++++++
> > include/linux/kdbus/reply.h | 68 +++++++++++
> > include/linux/kdbus/util.h | 74 +++++++++++
> > ipc/kdbus/Makefile | 2 +
> > ipc/kdbus/bus.h | 101 ---------------
> > ipc/kdbus/connection.h | 257 ---------------------------------------
> > ipc/kdbus/domain.h | 77 ------------
> > ipc/kdbus/endpoint.h | 67 ----------
> > ipc/kdbus/fs.h | 28 -----
> > ipc/kdbus/handle.h | 85 -------------
> > ipc/kdbus/item.h | 64 ----------
> > ipc/kdbus/limits.h | 64 ----------
> > ipc/kdbus/match.h | 35 ------
> > ipc/kdbus/message.h | 133 --------------------
> > ipc/kdbus/metadata.h | 57 ---------
> > ipc/kdbus/names.h | 74 -----------
> > ipc/kdbus/node.h | 84 -------------
> > ipc/kdbus/notify.h | 30 -----
> > ipc/kdbus/policy.h | 51 --------
> > ipc/kdbus/pool.h | 46 -------
> > ipc/kdbus/queue.h | 92 --------------
> > ipc/kdbus/reply.h | 68 -----------
> > ipc/kdbus/util.h | 74 -----------
> > 39 files changed, 1489 insertions(+), 1487 deletions(-)
> > create mode 100644 include/linux/kdbus/bus.h
> > create mode 100644 include/linux/kdbus/connection.h
> > create mode 100644 include/linux/kdbus/domain.h
> > create mode 100644 include/linux/kdbus/endpoint.h
> > create mode 100644 include/linux/kdbus/fs.h
> > create mode 100644 include/linux/kdbus/handle.h
> > create mode 100644 include/linux/kdbus/item.h
> > create mode 100644 include/linux/kdbus/limits.h
> > create mode 100644 include/linux/kdbus/match.h
> > create mode 100644 include/linux/kdbus/message.h
> > create mode 100644 include/linux/kdbus/metadata.h
> > create mode 100644 include/linux/kdbus/names.h
> > create mode 100644 include/linux/kdbus/node.h
> > create mode 100644 include/linux/kdbus/notify.h
> > create mode 100644 include/linux/kdbus/policy.h
> > create mode 100644 include/linux/kdbus/pool.h
> > create mode 100644 include/linux/kdbus/queue.h
> > create mode 100644 include/linux/kdbus/reply.h
> > create mode 100644 include/linux/kdbus/util.h
> > delete mode 100644 ipc/kdbus/bus.h
> > delete mode 100644 ipc/kdbus/connection.h
> > delete mode 100644 ipc/kdbus/domain.h
> > delete mode 100644 ipc/kdbus/endpoint.h
> > delete mode 100644 ipc/kdbus/fs.h
> > delete mode 100644 ipc/kdbus/handle.h
> > delete mode 100644 ipc/kdbus/item.h
> > delete mode 100644 ipc/kdbus/limits.h
> > delete mode 100644 ipc/kdbus/match.h
> > delete mode 100644 ipc/kdbus/message.h
> > delete mode 100644 ipc/kdbus/metadata.h
> > delete mode 100644 ipc/kdbus/names.h
> > delete mode 100644 ipc/kdbus/node.h
> > delete mode 100644 ipc/kdbus/notify.h
> > delete mode 100644 ipc/kdbus/policy.h
> > delete mode 100644 ipc/kdbus/pool.h
> > delete mode 100644 ipc/kdbus/queue.h
> > delete mode 100644 ipc/kdbus/reply.h
> > delete mode 100644 ipc/kdbus/util.h
>
> I'd prefer if we only move the required structure definitions into a
> separate header. There is no reason to export all internal entry
> points.
Yes this sounds better. Having an overview of what is really needed as
suggested by David and how things may work would be nice.
> Anyway, this is a technicality that actually depends on the
> implemented LSM hooks. So I'd prefer if we discuss that in combination
> with the actual LSM patches. I'm not entirely sure which parts are
> needed. For testing-purposes, we can always use -I./ipc/kdbus/, right?
>
> Thanks
> David
--
Djalal Harouni
http://opendz.org
next prev parent reply other threads:[~2015-03-25 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 15:37 Paul Osmialowski
2015-03-25 15:37 ` [RFC PATCH] kdbus: move all kdbus headers to include/linux/kdbus Paul Osmialowski
2015-03-25 15:45 ` David Herrmann
2015-03-25 16:07 ` Paul Osmialowski
2015-03-25 16:11 ` Djalal Harouni [this message]
2015-03-25 22:02 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325161113.GA5177@dztty \
--to=tixxdz@opendz.org \
--cc=daniel@zonque.org \
--cc=dh.herrmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=l.skalski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.osmialowsk@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox