From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbbCYQLV (ORCPT ); Wed, 25 Mar 2015 12:11:21 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:34851 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbbCYQLS (ORCPT ); Wed, 25 Mar 2015 12:11:18 -0400 Date: Wed, 25 Mar 2015 17:11:13 +0100 From: Djalal Harouni To: David Herrmann Cc: Paul Osmialowski , Greg Kroah-Hartman , Daniel Mack , linux-kernel , Lukasz Skalski Subject: Re: [RFC PATCH] kdbus: move all kdbus headers to include/linux/kdbus Message-ID: <20150325161113.GA5177@dztty> References: <1427297835-19978-1-git-send-email-p.osmialowsk@samsung.com> <1427297835-19978-2-git-send-email-p.osmialowsk@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 04:45:33PM +0100, David Herrmann wrote: > Hi > > On Wed, Mar 25, 2015 at 4:37 PM, Paul Osmialowski > wrote: > > These headers are required to implement LSM hooks for kdbus > > and possibly other things that might deal with kdbus. > > > > Signed-off-by: Paul Osmialowski > > --- > > include/linux/kdbus/bus.h | 101 +++++++++++++++ > > include/linux/kdbus/connection.h | 257 +++++++++++++++++++++++++++++++++++++++ > > include/linux/kdbus/domain.h | 77 ++++++++++++ > > include/linux/kdbus/endpoint.h | 67 ++++++++++ > > include/linux/kdbus/fs.h | 28 +++++ > > include/linux/kdbus/handle.h | 85 +++++++++++++ > > include/linux/kdbus/item.h | 64 ++++++++++ > > include/linux/kdbus/limits.h | 64 ++++++++++ > > include/linux/kdbus/match.h | 35 ++++++ > > include/linux/kdbus/message.h | 133 ++++++++++++++++++++ > > include/linux/kdbus/metadata.h | 57 +++++++++ > > include/linux/kdbus/names.h | 74 +++++++++++ > > include/linux/kdbus/node.h | 84 +++++++++++++ > > include/linux/kdbus/notify.h | 30 +++++ > > include/linux/kdbus/policy.h | 51 ++++++++ > > include/linux/kdbus/pool.h | 46 +++++++ > > include/linux/kdbus/queue.h | 92 ++++++++++++++ > > include/linux/kdbus/reply.h | 68 +++++++++++ > > include/linux/kdbus/util.h | 74 +++++++++++ > > ipc/kdbus/Makefile | 2 + > > ipc/kdbus/bus.h | 101 --------------- > > ipc/kdbus/connection.h | 257 --------------------------------------- > > ipc/kdbus/domain.h | 77 ------------ > > ipc/kdbus/endpoint.h | 67 ---------- > > ipc/kdbus/fs.h | 28 ----- > > ipc/kdbus/handle.h | 85 ------------- > > ipc/kdbus/item.h | 64 ---------- > > ipc/kdbus/limits.h | 64 ---------- > > ipc/kdbus/match.h | 35 ------ > > ipc/kdbus/message.h | 133 -------------------- > > ipc/kdbus/metadata.h | 57 --------- > > ipc/kdbus/names.h | 74 ----------- > > ipc/kdbus/node.h | 84 ------------- > > ipc/kdbus/notify.h | 30 ----- > > ipc/kdbus/policy.h | 51 -------- > > ipc/kdbus/pool.h | 46 ------- > > ipc/kdbus/queue.h | 92 -------------- > > ipc/kdbus/reply.h | 68 ----------- > > ipc/kdbus/util.h | 74 ----------- > > 39 files changed, 1489 insertions(+), 1487 deletions(-) > > create mode 100644 include/linux/kdbus/bus.h > > create mode 100644 include/linux/kdbus/connection.h > > create mode 100644 include/linux/kdbus/domain.h > > create mode 100644 include/linux/kdbus/endpoint.h > > create mode 100644 include/linux/kdbus/fs.h > > create mode 100644 include/linux/kdbus/handle.h > > create mode 100644 include/linux/kdbus/item.h > > create mode 100644 include/linux/kdbus/limits.h > > create mode 100644 include/linux/kdbus/match.h > > create mode 100644 include/linux/kdbus/message.h > > create mode 100644 include/linux/kdbus/metadata.h > > create mode 100644 include/linux/kdbus/names.h > > create mode 100644 include/linux/kdbus/node.h > > create mode 100644 include/linux/kdbus/notify.h > > create mode 100644 include/linux/kdbus/policy.h > > create mode 100644 include/linux/kdbus/pool.h > > create mode 100644 include/linux/kdbus/queue.h > > create mode 100644 include/linux/kdbus/reply.h > > create mode 100644 include/linux/kdbus/util.h > > delete mode 100644 ipc/kdbus/bus.h > > delete mode 100644 ipc/kdbus/connection.h > > delete mode 100644 ipc/kdbus/domain.h > > delete mode 100644 ipc/kdbus/endpoint.h > > delete mode 100644 ipc/kdbus/fs.h > > delete mode 100644 ipc/kdbus/handle.h > > delete mode 100644 ipc/kdbus/item.h > > delete mode 100644 ipc/kdbus/limits.h > > delete mode 100644 ipc/kdbus/match.h > > delete mode 100644 ipc/kdbus/message.h > > delete mode 100644 ipc/kdbus/metadata.h > > delete mode 100644 ipc/kdbus/names.h > > delete mode 100644 ipc/kdbus/node.h > > delete mode 100644 ipc/kdbus/notify.h > > delete mode 100644 ipc/kdbus/policy.h > > delete mode 100644 ipc/kdbus/pool.h > > delete mode 100644 ipc/kdbus/queue.h > > delete mode 100644 ipc/kdbus/reply.h > > delete mode 100644 ipc/kdbus/util.h > > I'd prefer if we only move the required structure definitions into a > separate header. There is no reason to export all internal entry > points. Yes this sounds better. Having an overview of what is really needed as suggested by David and how things may work would be nice. > Anyway, this is a technicality that actually depends on the > implemented LSM hooks. So I'd prefer if we discuss that in combination > with the actual LSM patches. I'm not entirely sure which parts are > needed. For testing-purposes, we can always use -I./ipc/kdbus/, right? > > Thanks > David -- Djalal Harouni http://opendz.org