public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: David Ahern <david.ahern@oracle.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH] perf record: Allow poll timeout to be specified
Date: Wed, 25 Mar 2015 19:20:52 +0100	[thread overview]
Message-ID: <20150325182052.GA8938@gmail.com> (raw)
In-Reply-To: <5512C903.6070905@oracle.com>


* David Ahern <david.ahern@oracle.com> wrote:

> On 3/25/15 6:14 AM, Arnaldo Carvalho de Melo wrote:
> >If David doesn't come up with something I'll probably will, as making
> >'trace' use the ordered_samples, like 'perf top' does (initially with
> >some arbitrary reasonable poll timeout value), is a low hanging fruit to
> >get those multi-CPU tracepoints sorted until I get something better in
> >place...
> 
> I have thought about it. It needs to be an adaptive algorithm:
> 1. start at 100 msec.
> 2. Read the maps. How much data are there (not events, but data size)? 3.
> Adjust poll timeout up or down with some heuristic -- maybe something
> similar to the algorithm perf-top uses for removing entries from the
> histograms.
> 
> That said, I still thinking giving the user control is not a crazy idea.

The user has absolutely zero control over the rate of data and about 
what the ideal refresh rate would be! So this really should be solved 
in software and automatically.

'try to tweak this parameter up and down until the tool is usable' is 
a really, really poor user interface concept ...

Thanks,

	Ingo

  reply	other threads:[~2015-03-25 18:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 16:09 [PATCH] perf record: Allow poll timeout to be specified David Ahern
2015-03-24 16:12 ` Ingo Molnar
2015-03-24 16:18   ` David Ahern
2015-03-24 21:21   ` Arnaldo Carvalho de Melo
2015-03-25  9:11     ` Ingo Molnar
2015-03-25 12:14       ` Arnaldo Carvalho de Melo
2015-03-25 14:41         ` David Ahern
2015-03-25 18:20           ` Ingo Molnar [this message]
2015-03-25 12:38 ` Jiri Olsa
2015-03-25 14:37   ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150325182052.GA8938@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=david.ahern@oracle.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox