* [PATCH 1/1] nfsd: incorrect check for debugfs returns @ 2015-03-24 2:58 Chengyu Song 2015-03-24 10:44 ` Jeff Layton 2015-03-25 15:17 ` J. Bruce Fields 0 siblings, 2 replies; 8+ messages in thread From: Chengyu Song @ 2015-03-24 2:58 UTC (permalink / raw) To: bfields, linux-nfs, linux-kernel Cc: taesoo, changwoo, sanidhya, blee, csong84 debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs is not configured, so the return value should be checked against ERROR_VALUE as well, otherwise the later dereference of the dentry pointer would crash the kernel. Signed-off-by: Chengyu Song <csong84@gatech.edu> --- fs/nfsd/fault_inject.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c index c16bf5a..621d065 100644 --- a/fs/nfsd/fault_inject.c +++ b/fs/nfsd/fault_inject.c @@ -132,19 +132,23 @@ int nfsd_fault_inject_init(void) unsigned int i; struct nfsd_fault_inject_op *op; umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; + struct dentry *dent; - debug_dir = debugfs_create_dir("nfsd", NULL); - if (!debug_dir) + dent = debugfs_create_dir("nfsd", NULL); + if (IS_ERR_OR_NULL(dent)) goto fail; + debug_dir = dent; for (i = 0; i < NUM_INJECT_OPS; i++) { op = &inject_ops[i]; - if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) + dent = debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd); + if (IS_ERR_OR_NULL(dent)) goto fail; + } return 0; fail: nfsd_fault_inject_cleanup(); - return -ENOMEM; + return dent ? PTR_ERR(dent) : -ENOMEM; } -- 2.1.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] nfsd: incorrect check for debugfs returns 2015-03-24 2:58 [PATCH 1/1] nfsd: incorrect check for debugfs returns Chengyu Song @ 2015-03-24 10:44 ` Jeff Layton 2015-03-25 15:08 ` J. Bruce Fields 2015-03-25 15:17 ` J. Bruce Fields 1 sibling, 1 reply; 8+ messages in thread From: Jeff Layton @ 2015-03-24 10:44 UTC (permalink / raw) To: Chengyu Song Cc: bfields, linux-nfs, linux-kernel, taesoo, changwoo, sanidhya, blee On Mon, 23 Mar 2015 22:58:05 -0400 Chengyu Song <csong84@gatech.edu> wrote: > debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs > is not configured, so the return value should be checked against ERROR_VALUE > as well, otherwise the later dereference of the dentry pointer would crash > the kernel. > > Signed-off-by: Chengyu Song <csong84@gatech.edu> > --- > fs/nfsd/fault_inject.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c > index c16bf5a..621d065 100644 > --- a/fs/nfsd/fault_inject.c > +++ b/fs/nfsd/fault_inject.c > @@ -132,19 +132,23 @@ int nfsd_fault_inject_init(void) > unsigned int i; > struct nfsd_fault_inject_op *op; > umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; > + struct dentry *dent; > > - debug_dir = debugfs_create_dir("nfsd", NULL); > - if (!debug_dir) > + dent = debugfs_create_dir("nfsd", NULL); > + if (IS_ERR_OR_NULL(dent)) > goto fail; > + debug_dir = dent; > > for (i = 0; i < NUM_INJECT_OPS; i++) { > op = &inject_ops[i]; > - if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) > + dent = debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd); > + if (IS_ERR_OR_NULL(dent)) > goto fail; > + > } > return 0; > > fail: > nfsd_fault_inject_cleanup(); > - return -ENOMEM; > + return dent ? PTR_ERR(dent) : -ENOMEM; > } No objection to taking this patch in the near term if it helps, but we had discussed over the summer just removing the NFS fault injection framework. Bruce, any objections to making that happen for v4.1? -- Jeff Layton <jeff.layton@primarydata.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] nfsd: incorrect check for debugfs returns 2015-03-24 10:44 ` Jeff Layton @ 2015-03-25 15:08 ` J. Bruce Fields 2015-03-25 15:49 ` Jeff Layton 0 siblings, 1 reply; 8+ messages in thread From: J. Bruce Fields @ 2015-03-25 15:08 UTC (permalink / raw) To: Jeff Layton Cc: Chengyu Song, linux-nfs, linux-kernel, taesoo, changwoo, sanidhya, blee On Tue, Mar 24, 2015 at 06:44:20AM -0400, Jeff Layton wrote: > On Mon, 23 Mar 2015 22:58:05 -0400 > Chengyu Song <csong84@gatech.edu> wrote: > > > debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs > > is not configured, so the return value should be checked against ERROR_VALUE > > as well, otherwise the later dereference of the dentry pointer would crash > > the kernel. > > > > Signed-off-by: Chengyu Song <csong84@gatech.edu> > > --- > > fs/nfsd/fault_inject.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c > > index c16bf5a..621d065 100644 > > --- a/fs/nfsd/fault_inject.c > > +++ b/fs/nfsd/fault_inject.c > > @@ -132,19 +132,23 @@ int nfsd_fault_inject_init(void) > > unsigned int i; > > struct nfsd_fault_inject_op *op; > > umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; > > + struct dentry *dent; > > > > - debug_dir = debugfs_create_dir("nfsd", NULL); > > - if (!debug_dir) > > + dent = debugfs_create_dir("nfsd", NULL); > > + if (IS_ERR_OR_NULL(dent)) > > goto fail; > > + debug_dir = dent; > > > > for (i = 0; i < NUM_INJECT_OPS; i++) { > > op = &inject_ops[i]; > > - if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) > > + dent = debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd); > > + if (IS_ERR_OR_NULL(dent)) > > goto fail; > > + > > } > > return 0; > > > > fail: > > nfsd_fault_inject_cleanup(); > > - return -ENOMEM; > > + return dent ? PTR_ERR(dent) : -ENOMEM; > > } > > No objection to taking this patch in the near term if it helps, but we > had discussed over the summer just removing the NFS fault injection > framework. > > Bruce, any objections to making that happen for v4.1? I was prepared to, but I think Redhat QA people told me that they do use it--which means other people may too, so I'm sort of reluctant to tear it out even if it's imperfect. --b. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] nfsd: incorrect check for debugfs returns 2015-03-25 15:08 ` J. Bruce Fields @ 2015-03-25 15:49 ` Jeff Layton 0 siblings, 0 replies; 8+ messages in thread From: Jeff Layton @ 2015-03-25 15:49 UTC (permalink / raw) To: J. Bruce Fields Cc: Chengyu Song, linux-nfs, linux-kernel, taesoo, changwoo, sanidhya, blee On Wed, 25 Mar 2015 11:08:56 -0400 "J. Bruce Fields" <bfields@fieldses.org> wrote: > On Tue, Mar 24, 2015 at 06:44:20AM -0400, Jeff Layton wrote: > > On Mon, 23 Mar 2015 22:58:05 -0400 > > Chengyu Song <csong84@gatech.edu> wrote: > > > > > debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs > > > is not configured, so the return value should be checked against ERROR_VALUE > > > as well, otherwise the later dereference of the dentry pointer would crash > > > the kernel. > > > > > > Signed-off-by: Chengyu Song <csong84@gatech.edu> > > > --- > > > fs/nfsd/fault_inject.c | 12 ++++++++---- > > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > > > diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c > > > index c16bf5a..621d065 100644 > > > --- a/fs/nfsd/fault_inject.c > > > +++ b/fs/nfsd/fault_inject.c > > > @@ -132,19 +132,23 @@ int nfsd_fault_inject_init(void) > > > unsigned int i; > > > struct nfsd_fault_inject_op *op; > > > umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; > > > + struct dentry *dent; > > > > > > - debug_dir = debugfs_create_dir("nfsd", NULL); > > > - if (!debug_dir) > > > + dent = debugfs_create_dir("nfsd", NULL); > > > + if (IS_ERR_OR_NULL(dent)) > > > goto fail; > > > + debug_dir = dent; > > > > > > for (i = 0; i < NUM_INJECT_OPS; i++) { > > > op = &inject_ops[i]; > > > - if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) > > > + dent = debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd); > > > + if (IS_ERR_OR_NULL(dent)) > > > goto fail; > > > + > > > } > > > return 0; > > > > > > fail: > > > nfsd_fault_inject_cleanup(); > > > - return -ENOMEM; > > > + return dent ? PTR_ERR(dent) : -ENOMEM; > > > } > > > > No objection to taking this patch in the near term if it helps, but we > > had discussed over the summer just removing the NFS fault injection > > framework. > > > > Bruce, any objections to making that happen for v4.1? > > I was prepared to, but I think Redhat QA people told me that they do use > it--which means other people may too, so I'm sort of reluctant to tear > it out even if it's imperfect. > > --b. Fair enough then. I'll leave it be... -- Jeff Layton <jeff.layton@primarydata.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] nfsd: incorrect check for debugfs returns 2015-03-24 2:58 [PATCH 1/1] nfsd: incorrect check for debugfs returns Chengyu Song 2015-03-24 10:44 ` Jeff Layton @ 2015-03-25 15:17 ` J. Bruce Fields 2015-03-25 16:41 ` Chengyu Song 1 sibling, 1 reply; 8+ messages in thread From: J. Bruce Fields @ 2015-03-25 15:17 UTC (permalink / raw) To: Chengyu Song; +Cc: linux-nfs, linux-kernel, taesoo, changwoo, sanidhya, blee On Mon, Mar 23, 2015 at 10:58:05PM -0400, Chengyu Song wrote: > debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs > is not configured, so the return value should be checked against ERROR_VALUE > as well, otherwise the later dereference of the dentry pointer would crash > the kernel. Thanks for spotting this. But it looks like this will cause nfsd startup to fail when debugfs isn't configured. I'd rather we didn't, it just isn't that important. So I'd rather just make nfsd_fault_inject_init() a void return--just do a dprintk as a warning in the "fail" case, and otherwise let normal startup continue (and check that doesn't lead to other unsafe dereferences of debug_dir). Could you try that? --b. > > Signed-off-by: Chengyu Song <csong84@gatech.edu> > --- > fs/nfsd/fault_inject.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c > index c16bf5a..621d065 100644 > --- a/fs/nfsd/fault_inject.c > +++ b/fs/nfsd/fault_inject.c > @@ -132,19 +132,23 @@ int nfsd_fault_inject_init(void) > unsigned int i; > struct nfsd_fault_inject_op *op; > umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; > + struct dentry *dent; > > - debug_dir = debugfs_create_dir("nfsd", NULL); > - if (!debug_dir) > + dent = debugfs_create_dir("nfsd", NULL); > + if (IS_ERR_OR_NULL(dent)) > goto fail; > + debug_dir = dent; > > for (i = 0; i < NUM_INJECT_OPS; i++) { > op = &inject_ops[i]; > - if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) > + dent = debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd); > + if (IS_ERR_OR_NULL(dent)) > goto fail; > + > } > return 0; > > fail: > nfsd_fault_inject_cleanup(); > - return -ENOMEM; > + return dent ? PTR_ERR(dent) : -ENOMEM; > } > -- > 2.1.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] nfsd: incorrect check for debugfs returns 2015-03-25 15:17 ` J. Bruce Fields @ 2015-03-25 16:41 ` Chengyu Song 2015-03-25 20:09 ` J. Bruce Fields 0 siblings, 1 reply; 8+ messages in thread From: Chengyu Song @ 2015-03-25 16:41 UTC (permalink / raw) To: J. Bruce Fields Cc: linux-nfs, linux-kernel, Taesoo Kim, changwoo, sanidhya, Byoungyoung Lee There may be a simpler solution, declare NFSD_FAULT_INJECTION has dependency on DEBUG_FS, or automatically select DEBUG_FS. I don't think current debugfs implementation will return any error ptr once it's configured. I choose to check the return instead, because I was worried the debugfs interface may change in the future. Does this sounds like a solution? If so, I can submit a patch for Kconfig. Best, Chengyu > On Mar 25, 2015, at 11:17 AM, J. Bruce Fields <bfields@fieldses.org> wrote: > > On Mon, Mar 23, 2015 at 10:58:05PM -0400, Chengyu Song wrote: >> debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs >> is not configured, so the return value should be checked against ERROR_VALUE >> as well, otherwise the later dereference of the dentry pointer would crash >> the kernel. > > Thanks for spotting this. But it looks like this will cause nfsd > startup to fail when debugfs isn't configured. I'd rather we didn't, it > just isn't that important. > > So I'd rather just make nfsd_fault_inject_init() a void return--just do > a dprintk as a warning in the "fail" case, and otherwise let normal > startup continue (and check that doesn't lead to other unsafe > dereferences of debug_dir). Could you try that? > > --b. > > >> >> Signed-off-by: Chengyu Song <csong84@gatech.edu> >> --- >> fs/nfsd/fault_inject.c | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c >> index c16bf5a..621d065 100644 >> --- a/fs/nfsd/fault_inject.c >> +++ b/fs/nfsd/fault_inject.c >> @@ -132,19 +132,23 @@ int nfsd_fault_inject_init(void) >> unsigned int i; >> struct nfsd_fault_inject_op *op; >> umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; >> + struct dentry *dent; >> >> - debug_dir = debugfs_create_dir("nfsd", NULL); >> - if (!debug_dir) >> + dent = debugfs_create_dir("nfsd", NULL); >> + if (IS_ERR_OR_NULL(dent)) >> goto fail; >> + debug_dir = dent; >> >> for (i = 0; i < NUM_INJECT_OPS; i++) { >> op = &inject_ops[i]; >> - if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) >> + dent = debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd); >> + if (IS_ERR_OR_NULL(dent)) >> goto fail; >> + >> } >> return 0; >> >> fail: >> nfsd_fault_inject_cleanup(); >> - return -ENOMEM; >> + return dent ? PTR_ERR(dent) : -ENOMEM; >> } >> -- >> 2.1.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] nfsd: incorrect check for debugfs returns 2015-03-25 16:41 ` Chengyu Song @ 2015-03-25 20:09 ` J. Bruce Fields 2015-03-25 20:41 ` Chengyu Song 0 siblings, 1 reply; 8+ messages in thread From: J. Bruce Fields @ 2015-03-25 20:09 UTC (permalink / raw) To: Chengyu Song Cc: linux-nfs, linux-kernel, Taesoo Kim, changwoo, sanidhya, Byoungyoung Lee On Wed, Mar 25, 2015 at 12:41:29PM -0400, Chengyu Song wrote: > There may be a simpler solution, declare NFSD_FAULT_INJECTION has dependency > on DEBUG_FS, or automatically select DEBUG_FS. Oh, I forgot about that--you're right, NFSD_FAULT_INJECTION isn't useful without DEBUG_FS anyway, so, sure, let's do that. --b. > I don't think current debugfs > implementation will return any error ptr once it's configured. > > I choose to check the return instead, because I was worried the debugfs interface > may change in the future. > > Does this sounds like a solution? If so, I can submit a patch for Kconfig. > > Best, > Chengyu > > > On Mar 25, 2015, at 11:17 AM, J. Bruce Fields <bfields@fieldses.org> wrote: > > > > On Mon, Mar 23, 2015 at 10:58:05PM -0400, Chengyu Song wrote: > >> debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs > >> is not configured, so the return value should be checked against ERROR_VALUE > >> as well, otherwise the later dereference of the dentry pointer would crash > >> the kernel. > > > > Thanks for spotting this. But it looks like this will cause nfsd > > startup to fail when debugfs isn't configured. I'd rather we didn't, it > > just isn't that important. > > > > So I'd rather just make nfsd_fault_inject_init() a void return--just do > > a dprintk as a warning in the "fail" case, and otherwise let normal > > startup continue (and check that doesn't lead to other unsafe > > dereferences of debug_dir). Could you try that? > > > > --b. > > > > > >> > >> Signed-off-by: Chengyu Song <csong84@gatech.edu> > >> --- > >> fs/nfsd/fault_inject.c | 12 ++++++++---- > >> 1 file changed, 8 insertions(+), 4 deletions(-) > >> > >> diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c > >> index c16bf5a..621d065 100644 > >> --- a/fs/nfsd/fault_inject.c > >> +++ b/fs/nfsd/fault_inject.c > >> @@ -132,19 +132,23 @@ int nfsd_fault_inject_init(void) > >> unsigned int i; > >> struct nfsd_fault_inject_op *op; > >> umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; > >> + struct dentry *dent; > >> > >> - debug_dir = debugfs_create_dir("nfsd", NULL); > >> - if (!debug_dir) > >> + dent = debugfs_create_dir("nfsd", NULL); > >> + if (IS_ERR_OR_NULL(dent)) > >> goto fail; > >> + debug_dir = dent; > >> > >> for (i = 0; i < NUM_INJECT_OPS; i++) { > >> op = &inject_ops[i]; > >> - if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) > >> + dent = debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd); > >> + if (IS_ERR_OR_NULL(dent)) > >> goto fail; > >> + > >> } > >> return 0; > >> > >> fail: > >> nfsd_fault_inject_cleanup(); > >> - return -ENOMEM; > >> + return dent ? PTR_ERR(dent) : -ENOMEM; > >> } > >> -- > >> 2.1.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] nfsd: incorrect check for debugfs returns 2015-03-25 20:09 ` J. Bruce Fields @ 2015-03-25 20:41 ` Chengyu Song 0 siblings, 0 replies; 8+ messages in thread From: Chengyu Song @ 2015-03-25 20:41 UTC (permalink / raw) To: J. Bruce Fields Cc: linux-nfs, linux-kernel, Taesoo Kim, changwoo, sanidhya, Byoungyoung Lee Cool. Sent. > On Mar 25, 2015, at 4:09 PM, J. Bruce Fields <bfields@fieldses.org> wrote: > > On Wed, Mar 25, 2015 at 12:41:29PM -0400, Chengyu Song wrote: >> There may be a simpler solution, declare NFSD_FAULT_INJECTION has dependency >> on DEBUG_FS, or automatically select DEBUG_FS. > > Oh, I forgot about that--you're right, NFSD_FAULT_INJECTION isn't useful > without DEBUG_FS anyway, so, sure, let's do that. > > --b. > >> I don't think current debugfs >> implementation will return any error ptr once it's configured. >> >> I choose to check the return instead, because I was worried the debugfs interface >> may change in the future. >> >> Does this sounds like a solution? If so, I can submit a patch for Kconfig. >> >> Best, >> Chengyu >> >>> On Mar 25, 2015, at 11:17 AM, J. Bruce Fields <bfields@fieldses.org> wrote: >>> >>> On Mon, Mar 23, 2015 at 10:58:05PM -0400, Chengyu Song wrote: >>>> debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs >>>> is not configured, so the return value should be checked against ERROR_VALUE >>>> as well, otherwise the later dereference of the dentry pointer would crash >>>> the kernel. >>> >>> Thanks for spotting this. But it looks like this will cause nfsd >>> startup to fail when debugfs isn't configured. I'd rather we didn't, it >>> just isn't that important. >>> >>> So I'd rather just make nfsd_fault_inject_init() a void return--just do >>> a dprintk as a warning in the "fail" case, and otherwise let normal >>> startup continue (and check that doesn't lead to other unsafe >>> dereferences of debug_dir). Could you try that? >>> >>> --b. >>> >>> >>>> >>>> Signed-off-by: Chengyu Song <csong84@gatech.edu> >>>> --- >>>> fs/nfsd/fault_inject.c | 12 ++++++++---- >>>> 1 file changed, 8 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c >>>> index c16bf5a..621d065 100644 >>>> --- a/fs/nfsd/fault_inject.c >>>> +++ b/fs/nfsd/fault_inject.c >>>> @@ -132,19 +132,23 @@ int nfsd_fault_inject_init(void) >>>> unsigned int i; >>>> struct nfsd_fault_inject_op *op; >>>> umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; >>>> + struct dentry *dent; >>>> >>>> - debug_dir = debugfs_create_dir("nfsd", NULL); >>>> - if (!debug_dir) >>>> + dent = debugfs_create_dir("nfsd", NULL); >>>> + if (IS_ERR_OR_NULL(dent)) >>>> goto fail; >>>> + debug_dir = dent; >>>> >>>> for (i = 0; i < NUM_INJECT_OPS; i++) { >>>> op = &inject_ops[i]; >>>> - if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) >>>> + dent = debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd); >>>> + if (IS_ERR_OR_NULL(dent)) >>>> goto fail; >>>> + >>>> } >>>> return 0; >>>> >>>> fail: >>>> nfsd_fault_inject_cleanup(); >>>> - return -ENOMEM; >>>> + return dent ? PTR_ERR(dent) : -ENOMEM; >>>> } >>>> -- >>>> 2.1.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-25 20:41 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-24 2:58 [PATCH 1/1] nfsd: incorrect check for debugfs returns Chengyu Song 2015-03-24 10:44 ` Jeff Layton 2015-03-25 15:08 ` J. Bruce Fields 2015-03-25 15:49 ` Jeff Layton 2015-03-25 15:17 ` J. Bruce Fields 2015-03-25 16:41 ` Chengyu Song 2015-03-25 20:09 ` J. Bruce Fields 2015-03-25 20:41 ` Chengyu Song
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox