From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbbCZGjz (ORCPT ); Thu, 26 Mar 2015 02:39:55 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:43695 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbCZGjx (ORCPT ); Thu, 26 Mar 2015 02:39:53 -0400 Date: Thu, 26 Mar 2015 07:39:50 +0100 From: Pavel Machek To: Kishon Vijay Abraham I Cc: NeilBrown , Tony Lindgren , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, GTA04 owners , NeilBrown Subject: Re: [PATCH 1/5] usb: phy: twl4030: make runtime pm more reliable. Message-ID: <20150326063950.GA755@amd> References: <20150322223307.21765.62974.stgit@notabene.brown> <20150322223523.21765.3199.stgit@notabene.brown> <55132965.3090002@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55132965.3090002@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c > > index 8e87f54671f3..1a244f34b748 100644 > > --- a/drivers/phy/phy-twl4030-usb.c > > +++ b/drivers/phy/phy-twl4030-usb.c > > @@ -144,6 +144,16 @@ > > #define PMBR1 0x0D > > #define GPIO_USB_4PIN_ULPI_2430C (3 << 0) > > > > +/* > > + * If VBUS is valid or ID is ground, then we know a > > + * cable is present and we need to be runtime-enabled > > + */ > > +static inline bool cable_present(enum omap_musb_vbus_id_status stat) > > twl4030_cable_present? It is static function, no need for prefixes, they just make code harder to read. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html