From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751774AbbCZJhk (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Mar 2015 05:37:40 -0400
Received: from mail-wg0-f52.google.com ([74.125.82.52]:35179 "EHLO
	mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751227AbbCZJhh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Mar 2015 05:37:37 -0400
Date: Thu, 26 Mar 2015 10:37:32 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Denys Vlasenko <dvlasenk@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] x86/asm/entry/64: use smaller insns
Message-ID: <20150326093732.GC14706@gmail.com>
References: <1427303896-24023-1-git-send-email-dvlasenk@redhat.com>
 <1427303896-24023-3-git-send-email-dvlasenk@redhat.com>
 <CA+55aFwHuaj80NaRNZW3Jfzh7_=nsx5p5=07PXUpaYwLzH-T=Q@mail.gmail.com>
 <BD648FB0-CBC0-4DB5-893A-4D4986585413@zytor.com>
 <CA+55aFyJg1248Df6tj6KMA2o2KCQbZJ7i6POCPureVwzX91Dzg@mail.gmail.com>
 <20150326092712.GA27751@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150326092712.GA27751@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Borislav Petkov <bp@alien8.de> wrote:

> On Wed, Mar 25, 2015 at 05:05:50PM -0700, Linus Torvalds wrote:
> > so 'as' is clearly just stupid. It already takes the size of the
> > constant into account and generates different instructions. Why not
> > for the common 32-bit case too?
> 
> I think the destination register mandates which insn to use:
> 
>         mov $0x12345678, %rdi
>         mov $0x12345678, %edi
> 
> ...
> 
>   15:   48 c7 c7 78 56 34 12    mov    $0x12345678,%rdi
>   1c:   bf 78 56 34 12          mov    $0x12345678,%edi
> 
> and 'as' is perhaps not insolent enough to go and change it when 
> seeing the 32-bit constant.

Well, GAS generally has the freedom to use more optimal opcodes, as 
long as behavior on the CPU matches what the specified opcode does.

Saying that 'movq $0x1, %rdi' should map to the longer variant is 
defensible: there should probably always be a way to specify a very 
specific opcode even if it's not optimal - say I want to fill in an 
alignment space and don't want to use an extra NOP.

But here GAS generates the 10-byte opcode even if 'mov $0x12345678, 
%rdi' is used, which is an unforced error.

Thanks,

	Ingo