From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbbCZJxo (ORCPT ); Thu, 26 Mar 2015 05:53:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42480 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbbCZJxm (ORCPT ); Thu, 26 Mar 2015 05:53:42 -0400 Date: Thu, 26 Mar 2015 10:53:38 +0100 From: Greg KH To: Marek Belisko Cc: johan@kernel.org, corbet@lwn.net, linux-usb@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, gta04-owner@goldelico.com, "H. Nikolaus Schaller" Subject: Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id Message-ID: <20150326095338.GA30028@kroah.com> References: <1427316814-22276-1-git-send-email-marek@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427316814-22276-1-git-send-email-marek@goldelico.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 09:53:34PM +0100, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > While trying to test the Pyra GSM/GPS/3G module I had reconfigured > the USB interface by mistake and therefore needed to run a different > USB driver than CSC-ACM. It turned out that I need the "usbserial" driver. > > This file is an official description how to use it: > Documentation/usb/usb-serial.txt > > But it is outdated. The parameters vendor= and product= are no longer > available since ca. 3.12 which means that documentation is lagging behind > quite some time. > > Here was the solution: > > https://bbs.archlinux.org/viewtopic.php?id=175499 > > insmod usbserial vendor=0x#### product=0x#### > > becomes (first #### is vendor, second is product) > > modprobe usbserial > echo #### #### >/sys/bus/usb-serial/drivers/generic/new_id > > This patch changes the documentation file as needed. > > Signed-off-by: H. Nikolaus Schaller You are forwarding on a patch from someone else, why didn't you also sign-off on it? Do you not agree with it? thanks, greg k-h