From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, Dave Airlie <airlied@gmail.com>,
Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
Rusty Russell <rusty@rustcorp.com.au>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list:VIRTIO CORE,
NET..." <virtualization@lists.linux-foundation.org>,
"open list:ABI/API" <linux-api@vger.kernel.org>
Subject: Re: [virtio-dev] Re: [PATCH] Add virtio gpu driver.
Date: Thu, 26 Mar 2015 10:04:03 +0100 [thread overview]
Message-ID: <20150326095736-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1427359367.9779.9.camel@nilsson.home.kraxel.org>
On Thu, Mar 26, 2015 at 09:42:47AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > And is it possible to use offset within BAR and/or memory BARs?
> > If yes I'd strongly prefer this.
>
> What is the point? Do you want place virtio regions and vga framebuffer
> in the same pci bar? Why? virtio is mmio and traps into qemu on
> access, whereas the vga framebuffer is memory-backed (with dirty
> tracking turned on). Don't think this is a good idea, even though the
> memory api would probably allow to do this.
>
> cheers,
> Gerd
Absolutely, it's pretty common to mix regions in a BAR.
For example, we have virtio kick (ioeventfd backed,
handled in kernel) in same BAR as common and device
specific configuration.
We did the same thing you are now doing with the
virtio BAR, and now we have to maintain two code
bases, virtio pci config was designed to be future proof
so why not use it?
This is mostly just making sure we don't paint ourselves into a corner.
--
MST
next prev parent reply other threads:[~2015-03-26 9:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 16:07 [PATCH] Add virtio gpu driver Gerd Hoffmann
2015-03-24 16:15 ` Michael S. Tsirkin
2015-03-25 14:52 ` Gerd Hoffmann
2015-03-25 15:24 ` Michael S. Tsirkin
2015-03-25 15:37 ` Gerd Hoffmann
2015-03-25 17:09 ` Michael S. Tsirkin
2015-03-26 7:12 ` Gerd Hoffmann
2015-03-26 8:18 ` Michael S. Tsirkin
2015-03-26 8:42 ` [virtio-dev] " Gerd Hoffmann
2015-03-26 9:04 ` Michael S. Tsirkin [this message]
2015-03-26 11:38 ` Gerd Hoffmann
2015-03-26 11:53 ` Michael S. Tsirkin
2015-03-26 15:07 ` Gerd Hoffmann
2015-03-26 16:47 ` Michael S. Tsirkin
2015-03-27 8:08 ` Gerd Hoffmann
2015-03-24 16:50 ` Daniel Vetter
2015-03-25 14:53 ` Gerd Hoffmann
2015-03-26 8:53 ` Daniel Vetter
2015-03-30 12:23 ` Gerd Hoffmann
2015-03-30 14:49 ` Daniel Vetter
2016-05-25 16:40 ` Daniel Vetter
2016-05-25 16:44 ` Emil Velikov
2016-05-27 7:48 ` Gerd Hoffmann
2016-05-27 9:03 ` Daniel Vetter
2016-05-30 13:50 ` Gerd Hoffmann
2016-05-30 14:47 ` Daniel Vetter
2016-05-31 6:29 ` Gerd Hoffmann
2016-05-31 6:55 ` Daniel Vetter
2016-05-31 7:00 ` Pekka Paalanen
2015-03-24 17:04 ` Michael S. Tsirkin
2015-03-24 20:47 ` Paul Bolle
2015-03-24 22:50 ` Daniel Stone
2015-03-25 0:00 ` Dave Airlie
2015-03-25 15:19 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326095736-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).