From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbbCZJEU (ORCPT ); Thu, 26 Mar 2015 05:04:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56527 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbCZJEQ (ORCPT ); Thu, 26 Mar 2015 05:04:16 -0400 Date: Thu, 26 Mar 2015 10:04:03 +0100 From: "Michael S. Tsirkin" To: Gerd Hoffmann Cc: virtio-dev@lists.oasis-open.org, Dave Airlie , Dave Airlie , David Airlie , Rusty Russell , open list , "open list:DRM DRIVERS" , "open list:VIRTIO CORE, NET..." , "open list:ABI/API" Subject: Re: [virtio-dev] Re: [PATCH] Add virtio gpu driver. Message-ID: <20150326095736-mutt-send-email-mst@redhat.com> References: <1427213239-8775-1-git-send-email-kraxel@redhat.com> <20150324171255-mutt-send-email-mst@redhat.com> <1427295121.23304.5.camel@nilsson.home.kraxel.org> <20150325162246-mutt-send-email-mst@redhat.com> <1427297836.23304.29.camel@nilsson.home.kraxel.org> <20150325180721-mutt-send-email-mst@redhat.com> <1427353959.9779.2.camel@nilsson.home.kraxel.org> <20150326091545-mutt-send-email-mst@redhat.com> <1427359367.9779.9.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427359367.9779.9.camel@nilsson.home.kraxel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 09:42:47AM +0100, Gerd Hoffmann wrote: > Hi, > > > And is it possible to use offset within BAR and/or memory BARs? > > If yes I'd strongly prefer this. > > What is the point? Do you want place virtio regions and vga framebuffer > in the same pci bar? Why? virtio is mmio and traps into qemu on > access, whereas the vga framebuffer is memory-backed (with dirty > tracking turned on). Don't think this is a good idea, even though the > memory api would probably allow to do this. > > cheers, > Gerd Absolutely, it's pretty common to mix regions in a BAR. For example, we have virtio kick (ioeventfd backed, handled in kernel) in same BAR as common and device specific configuration. We did the same thing you are now doing with the virtio BAR, and now we have to maintain two code bases, virtio pci config was designed to be future proof so why not use it? This is mostly just making sure we don't paint ourselves into a corner. -- MST