From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752490AbbCZKZi (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Mar 2015 06:25:38 -0400
Received: from mail-wg0-f42.google.com ([74.125.82.42]:34619 "EHLO
	mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751326AbbCZKZg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Mar 2015 06:25:36 -0400
Date: Thu, 26 Mar 2015 11:25:31 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Denys Vlasenko <dvlasenk@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] x86/asm/entry/64: use smaller insns
Message-ID: <20150326102531.GA19907@gmail.com>
References: <1427303896-24023-1-git-send-email-dvlasenk@redhat.com>
 <1427303896-24023-3-git-send-email-dvlasenk@redhat.com>
 <CA+55aFwHuaj80NaRNZW3Jfzh7_=nsx5p5=07PXUpaYwLzH-T=Q@mail.gmail.com>
 <BD648FB0-CBC0-4DB5-893A-4D4986585413@zytor.com>
 <CA+55aFyJg1248Df6tj6KMA2o2KCQbZJ7i6POCPureVwzX91Dzg@mail.gmail.com>
 <20150326092712.GA27751@pd.tnic>
 <20150326093732.GC14706@gmail.com>
 <CAK1hOcO+Z+1z7AMvTjH9efATMRaMN-pSvP4kdEJYXPPfLU_-oA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK1hOcO+Z+1z7AMvTjH9efATMRaMN-pSvP4kdEJYXPPfLU_-oA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Denys Vlasenko <vda.linux@googlemail.com> wrote:

> In my experiment, GAS uses 10-byte insn only for constants which
> won't work with 7-byte encoding; or if I explicitly ask for "movabs":
> 
> _start:         .globl  _start
>                 mov $0x12345678,%edi  # 5 bytes
>                 mov $0x12345678,%rdi  # 7 bytes
>                 movq $0x12345678,%rdi  # 7 bytes
>                 mov $0x80000000,%rdi  # 10 bytes
>                 mov $0x123456789,%rdi  # 10 bytes
>                 movabs $0x12345678,%rdi # 10 bytes
> 
> 
> $ gcc -nostartfiles -nostdlib -c z.S && objdump -dr z.o
> z.o:     file format elf64-x86-64
> Disassembly of section .text:
> 0000000000000000 <_start>:
>    0:    bf 78 56 34 12           mov    $0x12345678,%edi
>    5:    48 c7 c7 78 56 34 12     mov    $0x12345678,%rdi
>    c:    48 c7 c7 78 56 34 12     mov    $0x12345678,%rdi
>   13:    48 bf 00 00 00 80 00     movabs $0x80000000,%rdi
>   1a:    00 00 00
>   1d:    48 bf 89 67 45 23 01     movabs $0x123456789,%rdi
>   24:    00 00 00
>   27:    48 bf 78 56 34 12 00     movabs $0x12345678,%rdi
>   2e:    00 00 00

I see, so:

       movq $AUDIT_ARCH_X86_64, %rsi

generated a 10-byte MOVABS opcode, while moving into %esi generates 
the 5-byte 32-bit MOV opcode?

Thanks,

	Ingo