From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbbCZLmz (ORCPT ); Thu, 26 Mar 2015 07:42:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43372 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbbCZLmv (ORCPT ); Thu, 26 Mar 2015 07:42:51 -0400 Date: Thu, 26 Mar 2015 12:42:47 +0100 From: Greg KH To: Belisko Marek Cc: johan@kernel.org, corbet@lwn.net, Linux USB Mailing List , "linux-doc@vger.kernel.org" , LKML , GTA04 owners , "H. Nikolaus Schaller" Subject: Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id Message-ID: <20150326114247.GA16916@kroah.com> References: <1427316814-22276-1-git-send-email-marek@goldelico.com> <20150326095338.GA30028@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 11:41:24AM +0100, Belisko Marek wrote: > On Thu, Mar 26, 2015 at 10:53 AM, Greg KH wrote: > > On Wed, Mar 25, 2015 at 09:53:34PM +0100, Marek Belisko wrote: > >> From: "H. Nikolaus Schaller" > >> > >> While trying to test the Pyra GSM/GPS/3G module I had reconfigured > >> the USB interface by mistake and therefore needed to run a different > >> USB driver than CSC-ACM. It turned out that I need the "usbserial" driver. > >> > >> This file is an official description how to use it: > >> Documentation/usb/usb-serial.txt > >> > >> But it is outdated. The parameters vendor= and product= are no longer > >> available since ca. 3.12 which means that documentation is lagging behind > >> quite some time. > >> > >> Here was the solution: > >> > >> https://bbs.archlinux.org/viewtopic.php?id=175499 > >> > >> insmod usbserial vendor=0x#### product=0x#### > >> > >> becomes (first #### is vendor, second is product) > >> > >> modprobe usbserial > >> echo #### #### >/sys/bus/usb-serial/drivers/generic/new_id > >> > >> This patch changes the documentation file as needed. > >> > >> Signed-off-by: H. Nikolaus Schaller > > > > You are forwarding on a patch from someone else, why didn't you also > > sign-off on it? Do you not agree with it? > I wasn't involved in patch development I just review it and forward. If you reviewed and forwarded it, why did you not add a signed-off-by: to it? Do you not think it is acceptable for merging? If not, then we shouldn't either :) thanks, greg k-h