public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Benjamin Romer <benjamin.romer@unisys.com>,
	David Kershner <david.kershner@unisys.com>,
	devel@driverdev.osuosl.org, sparmaintainer@unisys.com,
	linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v5 1/5] staging: unisys: remove redundant variable
Date: Thu, 26 Mar 2015 13:01:24 +0100	[thread overview]
Message-ID: <20150326120124.GA17722@kroah.com> (raw)
In-Reply-To: <1427210250-30427-1-git-send-email-sudipm.mukherjee@gmail.com>

On Tue, Mar 24, 2015 at 08:47:26PM +0530, Sudip Mukherjee wrote:
> remove the variable "registered", which was used in the cleanup() to
> detect if the driver has successfully initialized. the cleanup()
> is called from module_exit, so its obvious that the module has
> successfully initialized. if the initialization had failed, then
> we will never be in the cleanup().
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> v5: reordered the patch series
> v4: messed up the subject in v3
> v3: broke the previous patch in series

I need an ack from Benjamin and/or David before I can take these, as
they are the maintainers of the driver, and have the ability to test
these patches.

I'll just wait to apply them until that happens.

Ben/David?

thanks,

greg k-h

  parent reply	other threads:[~2015-03-26 12:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 15:17 [PATCH v5 1/5] staging: unisys: remove redundant variable Sudip Mukherjee
2015-03-24 15:17 ` [PATCH v5 2/5] staging: unisys: use local variable Sudip Mukherjee
2015-03-24 15:17 ` [PATCH v5 3/5] staging: unisys: use local variable in cleanup Sudip Mukherjee
2015-03-24 15:17 ` [PATCH v5 4/5] staging: unisys: remove global dev_t Sudip Mukherjee
2015-03-24 15:17 ` [PATCH v5 5/5] staging: unisys: remove comparison Sudip Mukherjee
2015-03-24 15:27 ` [PATCH v5 1/5] staging: unisys: remove redundant variable Dan Carpenter
2015-03-26 12:01 ` Greg Kroah-Hartman [this message]
2015-03-26 13:47   ` Ben Romer
2015-03-26 17:13     ` Ben Romer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326120124.GA17722@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=benjamin.romer@unisys.com \
    --cc=dan.carpenter@oracle.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox