From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752302AbbCZMB3 (ORCPT ); Thu, 26 Mar 2015 08:01:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44552 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbbCZMB2 (ORCPT ); Thu, 26 Mar 2015 08:01:28 -0400 Date: Thu, 26 Mar 2015 13:01:24 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Benjamin Romer , David Kershner , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v5 1/5] staging: unisys: remove redundant variable Message-ID: <20150326120124.GA17722@kroah.com> References: <1427210250-30427-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427210250-30427-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 08:47:26PM +0530, Sudip Mukherjee wrote: > remove the variable "registered", which was used in the cleanup() to > detect if the driver has successfully initialized. the cleanup() > is called from module_exit, so its obvious that the module has > successfully initialized. if the initialization had failed, then > we will never be in the cleanup(). > > Signed-off-by: Sudip Mukherjee > --- > > v5: reordered the patch series > v4: messed up the subject in v3 > v3: broke the previous patch in series I need an ack from Benjamin and/or David before I can take these, as they are the maintainers of the driver, and have the ability to test these patches. I'll just wait to apply them until that happens. Ben/David? thanks, greg k-h