From: Greg KH <gregkh@linuxfoundation.org>
To: Niranjan Dighe <niranjan.dighe@gmail.com>
Cc: liodot@gmail.com, charrer@alacritech.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: slicoss: Fix checkpatch.pl issues
Date: Thu, 26 Mar 2015 13:12:03 +0100 [thread overview]
Message-ID: <20150326121203.GA22363@kroah.com> (raw)
In-Reply-To: <1427227123-8570-1-git-send-email-niranjan.dighe@gmail.com>
On Wed, Mar 25, 2015 at 01:28:43AM +0530, Niranjan Dighe wrote:
> Removed unused block of code guarded by #ifdef SLIC_TRACE_DUMP_ENABLED
> And removed redundant static char *slic_banner and replaced actual string in
> place of format string.
That's multiple things you are doing all in the same patch, please break
this up into multiple patches and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-26 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 19:58 [PATCH] Staging: slicoss: Fix checkpatch.pl issues Niranjan Dighe
2015-03-26 12:12 ` Greg KH [this message]
2015-03-26 18:21 ` [PATCH v2 1/2] Staging: slicoss: Remove redundant and disabled code block Niranjan Dighe
2015-03-26 18:22 ` [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable Niranjan Dighe
2015-03-26 18:33 ` Dan Carpenter
2015-03-26 18:52 ` Greg KH
2015-03-26 20:52 ` Joe Perches
2015-03-26 21:32 ` Greg KH
2015-03-26 21:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326121203.GA22363@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=niranjan.dighe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox