From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752590AbbCZMKr (ORCPT ); Thu, 26 Mar 2015 08:10:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33653 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbbCZMKo (ORCPT ); Thu, 26 Mar 2015 08:10:44 -0400 Date: Thu, 26 Mar 2015 13:10:40 +0100 From: "Michael S. Tsirkin" To: Gerd Hoffmann Cc: virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, David Herrmann , Dmitry Torokhov , Rusty Russell , open list , "open list:ABI/API" Subject: Re: [PATCH v5] Add virtio-input driver. Message-ID: <20150326130644-mutt-send-email-mst@redhat.com> References: <1427366965-32549-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427366965-32549-1-git-send-email-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 11:49:25AM +0100, Gerd Hoffmann wrote: > virtio-input is basically evdev-events-over-virtio, so this driver isn't > much more than reading configuration from config space and forwarding > incoming events to the linux input layer. > > Signed-off-by: Gerd Hoffmann Still a bit worried about using input.h as host/guest interface (can't we use some formal standard, e.g. USB HID?), but I'll let Rusty decide that. Otherwise mostly looks good. One nit below. > --- Could you pls include changelog in the future? You are sending multiple versions per day and it's hard to keep up. > +static unsigned int features[] = { > + /* none */ > +}; An empty line wouldn't hurt here about variable definition. > +static struct virtio_device_id id_table[] = { > + { VIRTIO_ID_INPUT, VIRTIO_DEV_ANY_ID }, > + { 0 }, > +};