From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616AbbCZNry (ORCPT ); Thu, 26 Mar 2015 09:47:54 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48335 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbbCZNrx (ORCPT ); Thu, 26 Mar 2015 09:47:53 -0400 Date: Thu, 26 Mar 2015 13:47:47 +0000 From: Mel Gorman To: Russell King - ARM Linux Cc: Gregory Fong , Laura Abbott , Florian Fainelli , Kees Cook , Nicolas Pitre , Catalin Marinas , open list , Yalin Wang , "linux-arm-kernel@lists.infradead.org" , vishnu.ps@samsung.com, Marek Szyprowski , Johannes Weiner Subject: Re: [PATCH] ARM: print cma-reserved pages from show_mem Message-ID: <20150326134747.GN4701@suse.de> References: <1423092164-9145-1-git-send-email-gregory.0xf0@gmail.com> <54D40DAF.4080609@codeaurora.org> <54D534FB.1090101@codeaurora.org> <20150210113230.GJ8656@n2100.arm.linux.org.uk> <20150326114612.GD8656@n2100.arm.linux.org.uk> <20150326123028.GM4701@suse.de> <20150326132258.GH8656@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20150326132258.GH8656@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 01:22:59PM +0000, Russell King - ARM Linux wrote: > On Thu, Mar 26, 2015 at 12:30:29PM +0000, Mel Gorman wrote: > > On Thu, Mar 26, 2015 at 11:46:12AM +0000, Russell King - ARM Linux wrote: > > > > > > > > > Looking at Mel's commit, I don't see a reason why we couldn't use that > > > solution - it gets rid of walking the page array, which has been fraught > > > in the past due to ARM having platforms which have holes in their > > > physical memory. > > > > > > We could try that solution - I don't see much downside to it. Most of > > > that information is as debug information for MM stuff anyway, and IMHO > > > > >From an MM perspective, I can tell you that the information is close to > > useless for debugging anything. It's why I ditched it in that commit and > > AFAIK, no one has ever cared. > > In that case, is there much point to show_mem()? Is it something which > should be considered for removal? > > If code serves no useful purpose anymore, we really ought to have a way Sorry I was not clear. show_mem itself is useful, the shared and non-shared values that commit c78e93630d15b5f5774213aad9bdc9f52473a89b removed are not. -- Mel Gorman SUSE Labs