Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver

Beomho Seo
2015-03-09T11:46:38Z

On 03/09/2015 08:02 PM, Krzysztof Kozlowski wrote:
> 2015-03-09 1:35 GMT+01:00 Beomho Seo <beomho.seo@samsung.com>:
>> On 03/08/2015 05:13 AM, Sebastian Reichel wrote:
>>> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote:
>>>> From: Beomho Seo <beomho.seo@samsung.com>
>>>>
>>>> This patch adds device driver of max77843 charger. This driver provide
>>>> initialize each charging mode(e.g. fast charge, top-off mode and constant
>>>> charging mode so on.). Additionally, control charging paramters to use
>>>> i2c interface.
>>>>
>>>> Cc: Sebastian Reichel <sre@kernel.org>
>>>> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
>>>
>>> Reviewed-By: Sebastian Reichel <sre@kernel.org>
>>>
>>> I can't take it as is, since it depends on the private header file
>>> of PATCHv1.
>>>
>>> -- Sebastian
>>>
>>
>> This patch reviewed by Sebastian.
>> Could you Please merge that your git tree ?
>
> Hi,
>
> ... and again we are adding a new driver for very similar chipset to
> already supported. I looked at spec and the charger's registers are
> almost the same as for max77693. Their layout and addresses are the
> same. I see some minor differences, probably the most important would
> be different values current (fast-charge, top-off). But still 90% of
> registers are the same... Do we really have to add new driver?
>
> Best regards,
> Krzysztof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

Hi,

Thank you for your comment. As you say, both chip set are similar.
But new driver need for support max77843. It is support different below
- Provide Battery presence information.
- Can OTG FET control.
- Bigger Fast charge current, Top Off current Threshold selection.
- Various and bigger OTG current limitation.
- Bigger primary charger termination voltage setting.
- Different maximum input current limit selection(Different step).

I respect your opinion but I think add new driver better.

Best regards,
Beomho Seo