From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753060AbbCZOMD (ORCPT ); Thu, 26 Mar 2015 10:12:03 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37364 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753020AbbCZOMA (ORCPT ); Thu, 26 Mar 2015 10:12:00 -0400 Date: Thu, 26 Mar 2015 14:11:54 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Alessandro Zummo , Sangbeom Kim , Samuel Ortiz , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Chanwoo Choi Subject: Re: [PATCH] rtc: s5m: Add support for S2MPS13 RTC Message-ID: <20150326141154.GN5951@x1> References: <1427207619-26742-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1427207619-26742-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote: > The S2MPS13 RTC is almost the same as S2MPS14. The differences when > updating alarm are: > 1. Set WUDR+AUDR field instead of WUDR+RUDR. > 2. Clear the AUDR field later (it is not auto-cleared). > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/rtc/rtc-s5m.c | 20 +++++++++++++++++++- > include/linux/mfd/samsung/rtc.h | 2 ++ > 2 files changed, 21 insertions(+), 1 deletion(-) [...] > diff --git a/include/linux/mfd/samsung/rtc.h b/include/linux/mfd/samsung/rtc.h > index b6401e7661c7..29c30ac36020 100644 > --- a/include/linux/mfd/samsung/rtc.h > +++ b/include/linux/mfd/samsung/rtc.h > @@ -105,6 +105,8 @@ enum s2mps_rtc_reg { > #define S5M_RTC_UDR_MASK (1 << S5M_RTC_UDR_SHIFT) > #define S2MPS_RTC_WUDR_SHIFT 4 > #define S2MPS_RTC_WUDR_MASK (1 << S2MPS_RTC_WUDR_SHIFT) > +#define S2MPS13_RTC_AUDR_SHIFT 1 > +#define S2MPS13_RTC_AUDR_MASK (1 << S2MPS13_RTC_AUDR_SHIFT) > #define S2MPS_RTC_RUDR_SHIFT 0 > #define S2MPS_RTC_RUDR_MASK (1 << S2MPS_RTC_RUDR_SHIFT) > #define RTC_TCON_SHIFT 1 Please consider writing these like: #define S2MPS_RTC_WUDR_MASK bit(4) #define S2MPS13_RTC_AUDR_MASK bit(1) #define S2MPS_RTC_RUDR_MASK bit(0) But for the MFD part of this patch: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog