From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbbCZOSU (ORCPT ); Thu, 26 Mar 2015 10:18:20 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36601 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752697AbbCZOSS (ORCPT ); Thu, 26 Mar 2015 10:18:18 -0400 Date: Thu, 26 Mar 2015 14:18:12 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: rtc-linux@googlegroups.com, Sangbeom Kim , Samuel Ortiz , Alessandro Zummo , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Chanwoo Choi Subject: Re: [rtc-linux] Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13 Message-ID: <20150326141812.GO5951@x1> References: <1426586058-15987-1-git-send-email-k.kozlowski@samsung.com> <1426586058-15987-2-git-send-email-k.kozlowski@samsung.com> <20150323123458.GE24804@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote: > 2015-03-23 13:34 GMT+01:00 Lee Jones : > > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > > > >> From: Chanwoo Choi > >> > >> This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is > >> equal to S2MPS14's RTC. > >> > >> Cc: Lee Jones > >> Suggested-by: Krzysztof Kozlowski > >> Signed-off-by: Chanwoo Choi > >> Signed-off-by: Krzysztof Kozlowski > >> > >> --- > >> > >> Changes since v1: > >> 1. New patch. > >> --- > >> drivers/mfd/sec-core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks. > > Hi, > > Sorry for the mess but we did this wrong. > The S2MPS13 RTC is slightly different than S2MPS14 and that difference > is important. It is embarrassing... but the difference was written > small-print as a note in datasheet. Really. I found it after carefully > comparing two PDFs. The impact of difference was not detected because > of error in DTS for Exynos5433-based board. > > This patch should be dropped (or reverted) and "s2mps13-rtc" should be > used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should > have its own support for RTC which I will add in separate patch. > > Lee, once again sorry for the mess. How would you like to proceed? Can > you just drop this commit? Patch removed -- panic averted. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog