From: Dan Carpenter <dan.carpenter@oracle.com>
To: Niranjan Dighe <niranjan.dighe@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
charrer@alacritech.com, liodot@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable
Date: Thu, 26 Mar 2015 21:33:47 +0300 [thread overview]
Message-ID: <20150326183347.GY10964@mwanda> (raw)
In-Reply-To: <1427394163-3074-1-git-send-email-niranjan.dighe@gmail.com>
On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> Replace string directly in place of format string and remove pointer
> variable which was used just once.
>
> Signed-off-by: Niranjan Dighe <niranjan.dighe@gmail.com>
>
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index c2bda1d..f3110f7 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -98,7 +98,6 @@
> #include "slic.h"
>
> static uint slic_first_init = 1;
> -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)";
>
> static char *slic_proc_version = "2.0.351 2006/07/14 12:26:00";
>
> @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev,
> return err;
>
> if (did_version++ == 0) {
> - dev_info(&pcidev->dev, "%s\n", slic_banner);
> + dev_info(&pcidev->dev,
> + "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n");
This indenting looks ugly.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-26 18:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 19:58 [PATCH] Staging: slicoss: Fix checkpatch.pl issues Niranjan Dighe
2015-03-26 12:12 ` Greg KH
2015-03-26 18:21 ` [PATCH v2 1/2] Staging: slicoss: Remove redundant and disabled code block Niranjan Dighe
2015-03-26 18:22 ` [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable Niranjan Dighe
2015-03-26 18:33 ` Dan Carpenter [this message]
2015-03-26 18:52 ` Greg KH
2015-03-26 20:52 ` Joe Perches
2015-03-26 21:32 ` Greg KH
2015-03-26 21:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326183347.GY10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=niranjan.dighe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox