From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753238AbbCZVXG (ORCPT ); Thu, 26 Mar 2015 17:23:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58336 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbbCZVXE (ORCPT ); Thu, 26 Mar 2015 17:23:04 -0400 Date: Thu, 26 Mar 2015 22:23:01 +0100 From: Greg KH To: Peter Hung Cc: jslaby@suse.cz, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH V2 RESEND 0/2] serial: 8250_pci: Fintek products patches Message-ID: <20150326212301.GA12137@kroah.com> References: <1426586535-6900-1-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426586535-6900-1-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2015 at 06:02:13PM +0800, Peter Hung wrote: > These series patches works for Fintek F81504/F81508/F81512 PCI to Serial Port. > and patch 0002 is following with patch 0001. > > patch 0001 is just cleanup non-used source code. > patch 0002 is major patch. > > The serial port of our product will failed after wakeup from S3(STR). > > It's due to when the system wakeup from S3(STR), this PCI device's > configuration space from 0x40 to 0x40 + max_port * 0x08 should be > re-configured. If had no re-configure, It's will all zero. > > We move all initialization from pci_fintek_setup() to pci_fintek_init() and > set it to pci_serial_quirks struct .init section. It's will re-init this > device when system wakeup from pciserial_resume_ports(). What changed from version 1? > Peter Hung (2): > serial: 8250_pci: remove non-used var for F81504 > serial: 8250_pci: port failed after wakeup from S3 > > drivers/tty/serial/8250/8250_pci.c | 121 +++++++++++++++---------------------- > 1 file changed, 50 insertions(+), 71 deletions(-) > mode change 100644 => 100755 drivers/tty/serial/8250/8250_pci.c You can't change the mode of a kernel file to executable, that's not allowed, and is a bug somewhere in your editor. Please fix this up and resend the series, I can't take these as-is. thanks, greg k-h