From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753480AbbCZWvL (ORCPT ); Thu, 26 Mar 2015 18:51:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59119 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753405AbbCZWvG (ORCPT ); Thu, 26 Mar 2015 18:51:06 -0400 Date: Thu, 26 Mar 2015 23:51:01 +0100 From: Greg KH To: Kumar Gala Cc: "Ivan T. Ivanov" , Gilad Avidov , sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, svarbanov@mm-sol.com, linux-kernel@vger.kernel.org, agross@codeaurora.org Subject: Re: [PATCH V5 0/2] add support for pmic_arb v2 and correct framework Message-ID: <20150326225101.GA18783@kroah.com> References: <1427305052-1284-1-git-send-email-gavidov@codeaurora.org> <1427363493.7093.4.camel@mm-sol.com> <79F9F7D5-8426-46DD-831B-08A0AD0FD6A7@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <79F9F7D5-8426-46DD-831B-08A0AD0FD6A7@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 10:26:09AM -0500, Kumar Gala wrote: > > On Mar 26, 2015, at 4:51 AM, Ivan T. Ivanov wrote: > > > > > On Wed, 2015-03-25 at 11:37 -0600, Gilad Avidov wrote: > >> pmic_arb v2 has no support for spmi non-data commands and thus > >> returns -EOPNOTSUPP on .cmd callback. This causes a failure in > >> spmi_drv_probe() which sends a wakeup command to the slave before > >> probing its driver. This patchset removes the wakeup from > >> spmi_drv_probe() since the spmi spec stipulates that a slaves > >> default state is active and doesn't need a wakeup. > >> > >> Changes from v3 to v4: > >> * Remove the claim that this is a bug fix off the commit text > >> * Unmap the core register space as soon as we know that it will not be used > >> * Assign the core reg space to a local until we know if it appropriate to use > >> it to configure the controller fields (on v1) or unmap it (on v2). > >> > >> Changes from v4 to v5: > >> * remove the unmap added in v4 since it is used again and the mapping is managed. > >> * correct printf formatting for 64bit compilers. > >> * correct base address for reading the channel table. > >> > >> Gilad Avidov (2): > >> spmi: remove wakeup command before slave probe > >> spmi: pmic_arb: add support for hw version 2 > > > > Thank you Gilad. This is fine now. Tested on APQ8084 > > (controller v1) and MSM8916 (controller v2). > > > > I am wandering which is the appropriate tree to merge this? > > > > Kumar? > > We’ve been asking Greg to pick up SPMI patches. Yes, I can take them. thanks, greg k-h