From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Juri Lelli <juri.lelli@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [PATCH v2] sched/deadline: reduce rq lock contention by eliminating locking of non-feasible target
Date: Fri, 27 Mar 2015 07:03:00 +0800 [thread overview]
Message-ID: <20150326230300.GA3658@kernel> (raw)
In-Reply-To: <1427101333-5841-1-git-send-email-wanpeng.li@linux.intel.com>
Ping Juri, ;)
On Mon, Mar 23, 2015 at 05:02:13PM +0800, Wanpeng Li wrote:
>This patch adds checks that prevents futile attempts to move dl tasks to
>a CPU with active tasks of equal or earlier deadline. The same behavior as
>commit 80e3d87b2c55 ("sched/rt: Reduce rq lock contention by eliminating
>locking of non-feasible target") for rt class.
>
>Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>---
>v1 -> v2:
> * use dl_time_before macro
>
> kernel/sched/deadline.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>index 19d716e..f48d319 100644
>--- a/kernel/sched/deadline.c
>+++ b/kernel/sched/deadline.c
>@@ -955,7 +955,9 @@ select_task_rq_dl(struct task_struct *p, int cpu, int sd_flag, int flags)
> (p->nr_cpus_allowed > 1)) {
> int target = find_later_rq(p);
>
>- if (target != -1)
>+ if (target != -1 &&
>+ dl_time_before(p->dl.deadline,
>+ cpu_rq(target)->dl.earliest_dl.curr))
> cpu = target;
> }
> rcu_read_unlock();
>--
>1.9.1
next prev parent reply other threads:[~2015-03-26 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 9:02 [PATCH v2] sched/deadline: reduce rq lock contention by eliminating locking of non-feasible target Wanpeng Li
2015-03-26 23:03 ` Wanpeng Li [this message]
2015-04-07 9:38 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326230300.GA3658@kernel \
--to=wanpeng.li@linux.intel.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox