* [PATCH] Staging: rtl8192 Clean up function definition
@ 2015-03-26 4:16 Eddie Kovsky
2015-03-26 8:37 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Eddie Kovsky @ 2015-03-26 4:16 UTC (permalink / raw)
To: gregkh, antoine, c, cristina.opriceana, rickard_strandqvist,
koray.gulcu, gdonald
Cc: devel, linux-kernel
Change function definition to match its prototype declaration. This
fixes the following warning generated by sparse:
drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol
'rtl8192_update_ratr_table' was not declared. Should it be static?
Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 8834c23d67fc..a4795afeeb9c 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -1967,7 +1967,7 @@ static int rtl8192_handle_assoc_response(struct net_device *dev,
}
-void rtl8192_update_ratr_table(struct net_device *dev)
+static void rtl8192_update_ratr_table(struct net_device *dev)
{
struct r8192_priv *priv = ieee80211_priv(dev);
struct ieee80211_device *ieee = priv->ieee80211;
--
2.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rtl8192 Clean up function definition
2015-03-26 4:16 [PATCH] Staging: rtl8192 Clean up function definition Eddie Kovsky
@ 2015-03-26 8:37 ` Dan Carpenter
2015-03-26 23:41 ` Eddie Kovsky
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2015-03-26 8:37 UTC (permalink / raw)
To: Eddie Kovsky
Cc: gregkh, antoine, c, cristina.opriceana, rickard_strandqvist,
koray.gulcu, gdonald, devel, linux-kernel
Huh. Weird. Please, could you just move it forward instead so we don't
have to have the prototype declaration?
regars,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: rtl8192 Clean up function definition
2015-03-26 8:37 ` Dan Carpenter
@ 2015-03-26 23:41 ` Eddie Kovsky
0 siblings, 0 replies; 3+ messages in thread
From: Eddie Kovsky @ 2015-03-26 23:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: gregkh, antoine, c, cristina.opriceana, rickard_strandqvist,
koray.gulcu, gdonald, devel, linux-kernel
On Thu, Mar 26, 2015 at 11:37:45AM +0300, Dan Carpenter wrote:
> Huh. Weird. Please, could you just move it forward instead so we don't
> have to have the prototype declaration?
>
> regars,
> dan carpenter
>
Dan
You're right. That's a better solution. But I already got a message from
Greg that he picked this up.
I'll put together another patch to remove the prototype.
Eddie
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-26 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-26 4:16 [PATCH] Staging: rtl8192 Clean up function definition Eddie Kovsky
2015-03-26 8:37 ` Dan Carpenter
2015-03-26 23:41 ` Eddie Kovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox