From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812AbbC0IrW (ORCPT ); Fri, 27 Mar 2015 04:47:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35407 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753789AbbC0IrV (ORCPT ); Fri, 27 Mar 2015 04:47:21 -0400 Date: Fri, 27 Mar 2015 09:47:16 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Benjamin Romer , David Kershner , sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: unisys: use error codes Message-ID: <20150327084716.GB1250@kroah.com> References: <1427445059-9534-1-git-send-email-sudipm.mukherjee@gmail.com> <1427445059-9534-2-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427445059-9534-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 02:00:58PM +0530, Sudip Mukherjee wrote: > we were just returning -1 to the calling function which was again > returning that if the module failed to load. Now we are returning the > actual error codes. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/unisys/visorchipset/file.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c > index 074c285..552febc 100644 > --- a/drivers/staging/unisys/visorchipset/file.c > +++ b/drivers/staging/unisys/visorchipset/file.c > @@ -56,18 +56,20 @@ visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel) > cdev_init(&file_cdev, &visorchipset_fops); > file_cdev.owner = THIS_MODULE; > if (MAJOR(major_dev) == 0) { > + rc = alloc_chrdev_region(&major_dev, 0, 1, MYDRVNAME); > /* dynamic major device number registration required */ > - if (alloc_chrdev_region(&major_dev, 0, 1, MYDRVNAME) < 0) > - return -1; > + if (rc < 0) > + return rc; > } else { > /* static major device number registration required */ > - if (register_chrdev_region(major_dev, 1, MYDRVNAME) < 0) > - return -1; > + rc = register_chrdev_region(major_dev, 1, MYDRVNAME); > + if (rc < 0) > + return rc; > } > rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1); > if (rc < 0) { > unregister_chrdev_region(major_dev, 1); > - return -1; > + return rc; I should have kept reading in the patch series, nice fix up :)