From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753891AbbC0Jp3 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Mar 2015 05:45:29 -0400
Received: from mail-pa0-f43.google.com ([209.85.220.43]:35784 "EHLO
	mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753551AbbC0Jp2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Mar 2015 05:45:28 -0400
Date: Fri, 27 Mar 2015 15:15:18 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Benjamin Romer <benjamin.romer@unisys.com>,
        David Kershner <david.kershner@unisys.com>, sparmaintainer@unisys.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: unisys: use error codes
Message-ID: <20150327094518.GA10353@sudip-PC>
References: <1427445059-9534-1-git-send-email-sudipm.mukherjee@gmail.com>
 <1427445059-9534-2-git-send-email-sudipm.mukherjee@gmail.com>
 <20150327084716.GB1250@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150327084716.GB1250@kroah.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 27, 2015 at 09:47:16AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 27, 2015 at 02:00:58PM +0530, Sudip Mukherjee wrote:
> >  	}
> >  	rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1);
> >  	if (rc  < 0) {
> >  		unregister_chrdev_region(major_dev, 1);
> > -		return -1;
> > +		return rc;
> 
> I should have kept reading in the patch series, nice fix up :)
some effect of learning from you and Dan :)

thanks