From: Dave Chinner <david@fromorbit.com>
To: Huang Ying <ying.huang@linux.intel.com>
Cc: Dave Chinner <dchinner@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, LKP ML <lkp@01.org>
Subject: Re: [LKP] [xfs] 834ffca6f7e: WARNING: CPU: 3 PID: 23390 at fs/xfs/xfs_file.c:700 xfs_file_dio_aio_write+0x27c/0x2e0()
Date: Fri, 27 Mar 2015 22:11:45 +1100 [thread overview]
Message-ID: <20150327111145.GH28129@dastard> (raw)
In-Reply-To: <1427416343.17170.58.camel@linux.intel.com>
On Fri, Mar 27, 2015 at 08:32:23AM +0800, Huang Ying wrote:
> On Fri, 2015-03-27 at 08:22 +1100, Dave Chinner wrote:
> > On Thu, Mar 26, 2015 at 02:45:19PM +0800, Huang Ying wrote:
> > > FYI, we noticed the below changes on
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > commit 834ffca6f7e345a79f6f2e2d131b0dfba8a4b67a ("xfs: don't zero partial page cache pages during O_DIRECT writes")
> >
> > Doing what test, exactly?
>
> Sorry, should include that information. We were running xfstests.
>
> generic/068 generic/100 generic/117 generic/120 generic/125 generic/130
> generic/192 generic/209 generic/223 generic/225 generic/226 generic/230
> generic/247 generic/256 generic/275
^^^^^^^^^^^
$ ./lsqa.pl tests/generic/247
FS QA Test No. 247
Test for race between direct I/O and mmap
$
i.e. xfstests runs tests designed specifically to hit direct IO vs
mmap races like this, so warnings about DIO/mmap races like this are
to be expected....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2015-03-27 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 6:45 [LKP] [xfs] 834ffca6f7e: WARNING: CPU: 3 PID: 23390 at fs/xfs/xfs_file.c:700 xfs_file_dio_aio_write+0x27c/0x2e0() Huang Ying
2015-03-26 21:22 ` Dave Chinner
2015-03-27 0:32 ` Huang Ying
2015-03-27 11:11 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327111145.GH28129@dastard \
--to=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=ying.huang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox