From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752536AbbC0LTC (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Mar 2015 07:19:02 -0400
Received: from mail-wi0-f173.google.com ([209.85.212.173]:37868 "EHLO
	mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751061AbbC0LTA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Mar 2015 07:19:00 -0400
Date: Fri, 27 Mar 2015 12:18:55 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Jeremie Galarneau <jgalar@efficios.com>,
        Namhyung Kim <namhyung@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Tom Zanussi <tzanussi@gmail.com>, Wang Nan <wangnan0@huawei.com>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf build: Suppress warning about missing libbabeltrace
Message-ID: <20150327111855.GB8749@gmail.com>
References: <1427451110-13480-1-git-send-email-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427451110-13480-1-git-send-email-jolsa@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jiri Olsa <jolsa@kernel.org> wrote:

> Be silent about missing babeltrace library until the needed
> version (1.3) is pushed into most common distros.
> 
> Requested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Link: http://lkml.kernel.org/n/tip-95mcd8hoxyt43jighilggjej@git.kernel.org
> ---
>  tools/perf/config/Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index cd121dfc4de9..2d9142b10cd3 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -606,7 +606,12 @@ ifndef NO_LIBBABELTRACE
>      EXTLIBS += -lbabeltrace-ctf
>      $(call detected,CONFIG_LIBBABELTRACE)
>    else
> -    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
> +#
> +# Be silent about missing babeltrace library
> +# until the needed version (1.3) is pushed
> +# into most common distros.
> +#
> +#    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
>      NO_LIBBABELTRACE := 1
>    endif
>  endif

But, but ... the feature detection is still executed, and it slows 
down the regular build on 99.9999% of the systems, right?

I don't mind carrying the code, but could we make it such that it 
needs some special option to build or so?

Thanks,

	Ingo