From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753255AbbC0MRz (ORCPT ); Fri, 27 Mar 2015 08:17:55 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43871 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbbC0MRw (ORCPT ); Fri, 27 Mar 2015 08:17:52 -0400 Date: Fri, 27 Mar 2015 13:17:42 +0100 From: Peter Zijlstra To: kan.liang@intel.com Cc: eranian@google.com, andi@firstfloor.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] perf/x86: filter branches for PEBS event Message-ID: <20150327121742.GE23123@twins.programming.kicks-ass.net> References: <1427393603-3533-1-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427393603-3533-1-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 02:13:23PM -0400, kan.liang@intel.com wrote: > This patch move intel_shared_regs_constraints for branch_reg ahead of > intel_pebs_constraints. Why not all shared regs? > intel_shared_regs_constraints for branch_reg doesn't modify event->hw, > so it's safe to be called before intel_pebs_constraints. > intel_shared_regs_constraints for branch_reg also special case when it > returns &emptyconstraint. It put constraints for extra_reg. This patch > remove it. Because it will never get constraints for extra_reg if return > is &emptyconstraint. -ENOPARSE.