[PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

[PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

[Witos]

Changed bool to u8.

Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
---
 drivers/staging/speakup/fakekey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
index 4299cf4..3dfb6bd 100644
--- a/drivers/staging/speakup/fakekey.c
+++ b/drivers/staging/speakup/fakekey.c
@@ -28,7 +28,7 @@
 #define PRESSED 1
 #define RELEASED 0
 
-static DEFINE_PER_CPU(bool, reporting_keystroke);
+static DEFINE_PER_CPU(u8, reporting_keystroke);
 
 static struct input_dev *virt_keyboard;
 
-- 
2.0.5

Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

[Greg Kroah-Hartman]

On Fri, Mar 27, 2015 at 09:29:43PM +0100, Witos wrote:
> Changed bool to u8.
> 
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>

Your From: email line and signed-off-by: line names do not match, so I
can't take this patch :(

Please fix up and resend.

> ---
>  drivers/staging/speakup/fakekey.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
> index 4299cf4..3dfb6bd 100644
> --- a/drivers/staging/speakup/fakekey.c
> +++ b/drivers/staging/speakup/fakekey.c
> @@ -28,7 +28,7 @@
>  #define PRESSED 1
>  #define RELEASED 0
>  
> -static DEFINE_PER_CPU(bool, reporting_keystroke);
> +static DEFINE_PER_CPU(u8, reporting_keystroke);

What is this fixing?  Why can't we have a bool as a per-cpu variable?
We are only writing true or false to it.

thanks,

greg k-h

[PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

[Witos]

Changed bool to u8 to get rid of sparse warning.

Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
---
 drivers/staging/speakup/fakekey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
index 4299cf4..3dfb6bd 100644
--- a/drivers/staging/speakup/fakekey.c
+++ b/drivers/staging/speakup/fakekey.c
@@ -28,7 +28,7 @@
 #define PRESSED 1
 #define RELEASED 0
 
-static DEFINE_PER_CPU(bool, reporting_keystroke);
+static DEFINE_PER_CPU(u8, reporting_keystroke);
 
 static struct input_dev *virt_keyboard;
 
-- 
2.0.5

Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

[Sudip Mukherjee]

On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> Changed bool to u8 to get rid of sparse warning.
but i am not getting this warning. which version of sparse are you
using?
and why you have sent the same patch two times?

regards
sudip

> 
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>

Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

[Piotr Witosławski]

On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote:
> On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> > Changed bool to u8 to get rid of sparse warning.
> but i am not getting this warning. which version of sparse are you
> using?

sparse 0.5.0, see: http://yarchive.net/comp/linux/bool.html

> and why you have sent the same patch two times?

sorry my mistake, first time I wanted send it to myself, I forgot
that I filled CC list. 

> 
> regards
> sudip
> 
> > 
> > Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>

Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

[Sudip Mukherjee]

On Sat, Mar 28, 2015 at 08:57:01AM +0100, Piotr Witosławski wrote:
> On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote:
> > On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> > > Changed bool to u8 to get rid of sparse warning.
> > but i am not getting this warning. which version of sparse are you
> > using?
> 
> sparse 0.5.0, see: http://yarchive.net/comp/linux/bool.html
looks like you have done quite a lot of research on it .. :)
i am using 0.5.0-22-gd92353b, and my sparse is not showing me this
warning.

regards
sudip
> 
> > and why you have sent the same patch two times?
> 
> sorry my mistake, first time I wanted send it to myself, I forgot
> that I filled CC list. 
> 
> > 
> > regards
> > sudip
> > 
> > > 
> > > Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>

Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

[Greg Kroah-Hartman]

On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> Changed bool to u8 to get rid of sparse warning.
> 
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
> ---
>  drivers/staging/speakup/fakekey.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
> index 4299cf4..3dfb6bd 100644
> --- a/drivers/staging/speakup/fakekey.c
> +++ b/drivers/staging/speakup/fakekey.c
> @@ -28,7 +28,7 @@
>  #define PRESSED 1
>  #define RELEASED 0
>  
> -static DEFINE_PER_CPU(bool, reporting_keystroke);
> +static DEFINE_PER_CPU(u8, reporting_keystroke);

Why send this twice?

And again, I don't think this is fixing anything, what is wrong with
this code?

confused,

greg k-h