public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: David Ahern <david.ahern@oracle.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: d63e2e1f3df breaks sparc/T5-8
Date: Sat, 28 Mar 2015 09:18:43 +0100	[thread overview]
Message-ID: <20150328081843.GA27114@ravnborg.org> (raw)
In-Reply-To: <CAE9FiQVHwR7ge-hFXq=xqOTZEzHdm5AqiwFC3HEcrTKxeDcePg@mail.gmail.com>

> >>  config ARM_THUMB
> >>       bool "Support Thumb user binaries" if !CPU_THUMBONLY
> >>       depends on CPU_ARM720T || CPU_ARM740T || CPU_ARM920T || CPU_ARM922T || \
> >> Index: linux-2.6/arch/arm64/Kconfig
> >> ===================================================================
> >> --- linux-2.6.orig/arch/arm64/Kconfig
> >> +++ linux-2.6/arch/arm64/Kconfig
> >> @@ -125,6 +125,9 @@ config HAVE_GENERIC_RCU_GUP
> >>  config ARCH_DMA_ADDR_T_64BIT
> >>       def_bool y
> >>
> >> +config ARCH_PCI_BUS_ADDR_T_64BIT
> >> +     def_bool y
> >> +
> > Use select
> ...
> 
> I was trying to keep the style to be consistent with old one in each Kconfig.
> 
> So do we just need to make sure new added lines to use new style?

Use new style select everywhere.
That could maybe in the future trigger someone to update the different arch
configs to use select for the remaining bits.

> >> Index: linux-2.6/include/linux/types.h
> >> ===================================================================
> >> --- linux-2.6.orig/include/linux/types.h
> >> +++ linux-2.6/include/linux/types.h
> >> @@ -146,6 +146,13 @@ typedef u64 dma_addr_t;
> >>  typedef u32 dma_addr_t;
> >>  #endif /* dma_addr_t */
> >>
> >> +/* A pci_bus_addr_t can hold pci bus address for the platform */
> >> +#ifdef CONFIG_ARCH_PCI_BUS_ADDR_T_64BIT
> >> +typedef u64 pci_bus_addr_t;
> >> +#else
> >> +typedef u32 pci_bus_addr_t;
> >> +#endif /* pci_bus_addr_t */
> >> +
> > Looking att all the Kconfig logic I get the impression that
> > the type of pci_bus_addr_t equals unsigned long.
> > If this is correct then you can skip that and things
> > gets much simpler.
> 
> For x86 32bit with PAE support, we could use 64bit for bus address.
> but unsigned long is 32bit.

Missed that part - OK.

	Sam

  reply	other threads:[~2015-03-28  8:19 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 16:51 d63e2e1f3df breaks sparc/T5-8 David Ahern
2015-03-26 20:43 ` Yinghai Lu
2015-03-26 23:27   ` David Ahern
2015-03-27 21:01     ` Yinghai Lu
2015-03-27 21:50       ` David Miller
2015-03-27 22:51         ` Yinghai Lu
     [not found]         ` <CABhMZUVqgsYdT4wn2H8hsrh4f=6hT0G+sg=wwYSt33+jtvBS9A@mail.gmail.com>
2015-03-29 18:32           ` David Miller
2015-04-03 15:45             ` Bjorn Helgaas
2015-04-03 16:48               ` David Miller
2015-03-27 23:57       ` Yinghai Lu
2015-03-28  0:32         ` David Ahern
2015-03-28  0:36           ` David Ahern
2015-03-28  3:19             ` Yinghai Lu
2015-03-28  3:22               ` David Ahern
2015-03-28  3:27                 ` Yinghai Lu
2015-03-28  3:45               ` David Ahern
2015-03-28  5:26                 ` Yinghai Lu
2015-03-28 14:48                   ` David Ahern
2015-03-28 20:24                     ` Yinghai Lu
2015-03-29 14:47                       ` David Ahern
2015-03-29 20:07                         ` Yinghai Lu
2015-03-30 22:54                           ` David Ahern
2015-03-31  1:06                             ` Yinghai Lu
2015-03-31  4:10                               ` David Ahern
2015-03-31 16:53                                 ` Yinghai Lu
2015-03-31 17:04                                   ` David Ahern
2015-03-31 20:28                                     ` Yinghai Lu
2015-03-31 22:29                                       ` David Ahern
2015-03-31 22:38                                         ` Yinghai Lu
2015-03-31 22:42                                           ` David Ahern
2015-03-31 15:06                               ` David Miller
2015-03-31 18:16                                 ` Yinghai Lu
2015-03-31 18:19                                   ` David Miller
2015-03-31 18:25                                     ` Yinghai Lu
2015-03-28  1:05         ` Sam Ravnborg
2015-03-28  2:07           ` Yinghai Lu
2015-03-28  8:18             ` Sam Ravnborg [this message]
2015-03-28 18:16         ` David Miller
2015-03-28 20:19           ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150328081843.GA27114@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=bhelgaas@google.com \
    --cc=david.ahern@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox