From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbbC1KmW (ORCPT ); Sat, 28 Mar 2015 06:42:22 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:38607 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbbC1KmU (ORCPT ); Sat, 28 Mar 2015 06:42:20 -0400 Date: Sat, 28 Mar 2015 03:42:10 -0700 From: "Paul E. McKenney" To: Patrick Marlier Cc: linux-kernel@vger.kernel.org, Josh Triplett Subject: Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw Message-ID: <20150328104210.GB28980@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <55113D0A.2030302@gmail.com> <20150325143018.GZ5718@linux.vnet.ibm.com> <5512CDC4.10203@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5512CDC4.10203@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15032810-0013-0000-0000-000009AFF679 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > >>Change to read effectively ptr with rcu_dereference_raw and not the > >>__ptr variable on the stack. > >> > >>Signed-off-by: Patrick Marlier > >Avoiding an extra load could be worthwhile in a number of situations, > >agreed. > Not only a load. It adds a store and a load on the stack and I think > this creates a dependency in the processor pipeline. > > >However, won't this change cause sparse to complain if invoked on a > >non-RCU-protected pointer? The ability to use list-RCU API > >members on both RCU and non-RCU pointers was one of the points > >of the previous commit, right? > Probably we can put back the cast but I am not familiar enough with > the RCU API. > > Also, the problem here is that you probably want ACCESS_ONCE to > happen on the content of 'ptr' and not on the stack variable > '__ptr'. > > (you have to follow this chain: rcu_dereference_raw -> > rcu_dereference_check -> __rcu_dereference_check -> > lockless_dereference -> ACCESS_ONCE) > > #define lockless_dereference(p) \ > ({ \ > typeof(p) _________p1 = ACCESS_ONCE(p); \ > smp_read_barrier_depends(); /* Dependency order vs. p above. */ \ > (_________p1); \ > }) > > #define __ACCESS_ONCE(x) ({ \ > __maybe_unused typeof(x) __var = (__force typeof(x)) 0; \ > (volatile typeof(x) *)&(x); }) > #define ACCESS_ONCE(x) (*__ACCESS_ONCE(x)) > > Note that ACCESS_ONCE is doing "&" on x. > > IMHO, I would prefer saving some useless instructions for better > performance rather than giving too much flexibility on the API (also > pretty sure the cast can be still done). OK, what I am going to do is to apply your patches for testing purposes. If there are no complaints, they will likely go into v4.3 or thereabouts. Thanx, Paul