Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

Dan Carpenter
2015-01-19T12:20:30Z

On Sun, Jan 18, 2015 at 09:29:21AM +0100, Robin Schroer wrote:
> On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> > index e9f0c15..141abb7 100644
> > --- a/drivers/staging/speakup/main.c
> > +++ b/drivers/staging/speakup/main.c
> > @@ -422,8 +422,10 @@ static void announce_edge(struct vc_data *vc, int msg_id)
> > {
> > if (spk_bleeps & 1)
> > bleep(spk_y);
> > - if ((spk_bleeps & 2) && (msg_id < edge_quiet))
> > - synth_printf("%s\n", spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> > + if ((spk_bleeps & 2) && (msg_id < edge_quiet)) {
> > + synth_printf("%s\n",
> > + spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> > + }
> > }
> >
> You do not actually need to add the braces as this remains a single
> statement (mnemonic: without braces the if ends at the first semicolon).
>

In staging (and most other trees), we prefer that the curly braces be
there for multi-line indents. It makes it more readable.

regards,
dan carpenter