From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751259AbbC2Gpu (ORCPT <rfc822;w@1wt.eu>);
	Sun, 29 Mar 2015 02:45:50 -0400
Received: from mail-wi0-f170.google.com ([209.85.212.170]:34649 "EHLO
	mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750895AbbC2Gpr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 29 Mar 2015 02:45:47 -0400
Date: Sun, 29 Mar 2015 08:45:43 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Nicolas Pitre <nicolas.pitre@linaro.org>, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, rjw@rjwysocki.net,
        Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based
 broadcasting
Message-ID: <20150329064542.GB17765@gmail.com>
References: <alpine.LFD.2.11.1502191124510.22104@knanqh.ubzr>
 <20150221124659.GG23367@worktop.ger.corp.intel.com>
 <alpine.LFD.2.11.1502211135230.25484@knanqh.ubzr>
 <20150223161457.GA5029@twins.programming.kicks-ass.net>
 <alpine.LFD.2.11.1502231124030.25484@knanqh.ubzr>
 <alpine.LFD.2.11.1502231214240.25484@knanqh.ubzr>
 <54EEAFCF.4080208@linux.vnet.ibm.com>
 <54F02F81.10901@linux.vnet.ibm.com>
 <20150302145635.GN21418@twins.programming.kicks-ass.net>
 <54F7D974.8030208@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54F7D974.8030208@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Preeti U Murthy <preeti@linux.vnet.ibm.com> wrote:

> On 03/02/2015 08:26 PM, Peter Zijlstra wrote:
> > On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote:
> >> The problem reported in the changelog of this patch is causing severe
> >> regressions very frequently on our machines for certain usecases. It would
> >> help to put in a fix in place first and then follow that up with these
> >> cleanups.  A fix on the below lines :
> > 
> > Regression how? Neither Thomas' Changelog, nor yours mention its a
> > regression.
> > 
> > If its a (recent) Regression you need to have a Fixes tag at the very
> > least. So when was this broken and by which patch?
> > 
> 
> It was found recently when doing a hotplug stress test on POWER, that
> the machine hits lockups spewing
> 
> NMI watchdog: BUG: soft lockup - CPU#20 stuck for 23s! [swapper/20:0]
> 
> or
> 
> INFO: rcu_sched detected stalls on CPUs/tasks: { 2 7 8 9 10 11 12 13 14 15
> 16 17 18 19 20 21 22 23 2
> 4 25 26 27 28 29 30 31} (detected by 6, t=2102 jiffies, g=1617, c=1616,
> q=1441)
> 
> and many other messages about lockups.
> 
> This issue was reported here:
> http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
> and was traced to
> commit 7cba160ad789a powernv/cpuidle: Redesign idle states management,
> which exposed the loophole in commit 5d1638acb9f6(tick: Introduce
> hrtimer based broadcast) and is reported in the changelog of the patch.

Please send the patch with an updated changelog.

Thanks,

	Ingo