From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbbC2XPv (ORCPT ); Sun, 29 Mar 2015 19:15:51 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:48156 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbbC2XPs (ORCPT ); Sun, 29 Mar 2015 19:15:48 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Mon, 30 Mar 2015 01:15:39 +0200 From: Stefan Richter To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups Message-ID: <20150330011539.4bfa5288@kant> In-Reply-To: <1427635734-24786-1-git-send-email-mst@redhat.com> References: <1427635734-24786-1-git-send-email-mst@redhat.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 29 Michael S. Tsirkin wrote: > The macros in pci_ids.h are pretty useful for userspace > using the pci sysfs interface, e.g. to decode class > device and vendor sysfs files. > > At the moment userspace is forced to duplicate these macros (e.g. QEMU does > this, so does gpxe, seabios, etc), it is better to export them in > /usr/include/linux/pci_ids.h so everyone can just include this header. > > This patchset is structured as follows: > 1. include/linux/pci_ids.h is moved to include/uapi/linux/pci_ids.h; > a stub file is created in include/linux/pci_ids.h to avoid breaking > bisect Since linux' include/linux/pci_ids.h is incomplete, I am doubtful that it is appropriate for userspace. > 2. all users are converted to use the new header This step should not be necessary. It has not been done with other headers which were moved to include/uapi. > 3. include/linux/pci_ids.h is removed > 4. cleanups for several issues detected during step 2 -- Stefan Richter -=====-===== --== ====- http://arcgraph.de/sr/