From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbbC3Cxr (ORCPT ); Sun, 29 Mar 2015 22:53:47 -0400 Received: from lgeamrelo01.lge.com ([156.147.1.125]:51226 "EHLO lgeamrelo01.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbbC3Cxp (ORCPT ); Sun, 29 Mar 2015 22:53:45 -0400 X-Original-SENDERIP: 10.177.220.203 X-Original-MAILFROM: namhyung@kernel.org Date: Mon, 30 Mar 2015 11:47:01 +0900 From: Namhyung Kim To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Masami Hiramatsu , Mathieu Desnoyers , Namjae Jeon , Pankaj Kumar , Jaegeuk Kim Subject: Re: [RFC][PATCH 05/10] f2fs: Export the enums in the tracepoints to userspace Message-ID: <20150330024701.GC32033@sejong> References: <20150327213704.857765144@goodmis.org> <20150327213813.925869241@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150327213813.925869241@goodmis.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 05:37:09PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > The tracepoints that use __print_symbolic() use enums as the value > to convert to strings. Unfortunately, the format files for these > tracepoints show the enum name and not their value. This causes some > userspace tools not to know how to convert __print_symbolic() to > their strings. > > Add TRACE_DEFINE_ENUM() macros to export the enums used to userspace > to let those tools know what those enum values are. > > Cc: Namjae Jeon > Cc: Pankaj Kumar > Cc: Jaegeuk Kim AFAIK Jaegeuk's samsung email is not valid anymore.. $ grep -a Jaegeuk MAINTAINERS M: Jaegeuk Kim Thanks, Namhyung > Signed-off-by: Steven Rostedt > --- > include/trace/events/f2fs.h | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h > index 5422dbfaf97d..a0074dd8d140 100644 > --- a/include/trace/events/f2fs.h > +++ b/include/trace/events/f2fs.h > @@ -9,6 +9,27 @@ > #define show_dev(entry) MAJOR(entry->dev), MINOR(entry->dev) > #define show_dev_ino(entry) show_dev(entry), (unsigned long)entry->ino > > +TRACE_DEFINE_ENUM(NODE); > +TRACE_DEFINE_ENUM(DATA); > +TRACE_DEFINE_ENUM(META_FLUSH); > +TRACE_DEFINE_ENUM(CURSEG_HOT_DATA); > +TRACE_DEFINE_ENUM(CURSEG_WARM_DATA); > +TRACE_DEFINE_ENUM(CURSEG_COLD_DATA); > +TRACE_DEFINE_ENUM(CURSEG_HOT_NODE); > +TRACE_DEFINE_ENUM(CURSEG_WARM_NODE); > +TRACE_DEFINE_ENUM(CURSEG_COLD_NODE); > +TRACE_DEFINE_ENUM(NO_CHECK_TYPE); > +TRACE_DEFINE_ENUM(GC_GREEDY); > +TRACE_DEFINE_ENUM(GC_CB); > +TRACE_DEFINE_ENUM(__REQ_RAHEAD); > +TRACE_DEFINE_ENUM(__REQ_WRITE); > +TRACE_DEFINE_ENUM(__REQ_SYNC); > +TRACE_DEFINE_ENUM(__REQ_NOIDLE); > +TRACE_DEFINE_ENUM(__REQ_FLUSH); > +TRACE_DEFINE_ENUM(__REQ_FUA); > +TRACE_DEFINE_ENUM(__REQ_PRIO); > +TRACE_DEFINE_ENUM(__REQ_META); > + > #define show_block_type(type) \ > __print_symbolic(type, \ > { NODE, "NODE" }, \ > -- > 2.1.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/