From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, "David Härdeman" <david@hardeman.nu>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 3/6] media/fintek: drop pci_ids dependency
Date: Mon, 30 Mar 2015 05:17:52 -0700 [thread overview]
Message-ID: <20150330051752.3923a027@concha.lan> (raw)
In-Reply-To: <1427712964-16155-4-git-send-email-mst@redhat.com>
Em Mon, 30 Mar 2015 12:59:32 +0200
"Michael S. Tsirkin" <mst@redhat.com> escreveu:
> This driver does not use any PCI IDs, don't include
> the pci_ids.h header.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Yeah, someone just cut and paste the dependencies from some other IR driver
without checking.
Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> ---
> drivers/media/rc/fintek-cir.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/rc/fintek-cir.c b/drivers/media/rc/fintek-cir.c
> index b516757..9ca168a 100644
> --- a/drivers/media/rc/fintek-cir.c
> +++ b/drivers/media/rc/fintek-cir.c
> @@ -33,7 +33,6 @@
> #include <linux/sched.h>
> #include <linux/slab.h>
> #include <media/rc-core.h>
> -#include <linux/pci_ids.h>
>
> #include "fintek-cir.h"
>
--
Cheers,
Mauro
next prev parent reply other threads:[~2015-03-30 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 10:59 [PATCH v2 0/6] pci.h/pci_ids.h related cleanups Michael S. Tsirkin
2015-03-30 10:59 ` [PATCH v2 1/6] crypto/ccp: drop linux/pci dependencies Michael S. Tsirkin
2015-03-30 10:59 ` [PATCH v2 2/6] input/serio: drop pci_ids dependency Michael S. Tsirkin
2015-04-06 16:24 ` Dmitry Torokhov
2015-03-30 10:59 ` [PATCH v2 3/6] media/fintek: " Michael S. Tsirkin
2015-03-30 12:17 ` Mauro Carvalho Chehab [this message]
2015-03-30 10:59 ` [PATCH v2 4/6] brcm80211: drop pci dependency Michael S. Tsirkin
2015-03-30 10:59 ` [PATCH v2 5/6] brcm80211: drop pci_ids include Michael S. Tsirkin
2015-03-30 10:59 ` [PATCH v2 6/6] staging/olpc: drop pci dependencies Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330051752.3923a027@concha.lan \
--to=mchehab@osg.samsung.com \
--cc=bhelgaas@google.com \
--cc=david@hardeman.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox