From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971AbbC3HMU (ORCPT ); Mon, 30 Mar 2015 03:12:20 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:38475 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724AbbC3HMT (ORCPT ); Mon, 30 Mar 2015 03:12:19 -0400 Date: Mon, 30 Mar 2015 08:12:14 +0100 From: Lee Jones To: Charles Keepax Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: arizona: Correct type of gpio_defaults Message-ID: <20150330071214.GG457@x1> References: <1427629542-28185-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1427629542-28185-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Mar 2015, Charles Keepax wrote: > gpio_defaults needs to be specified as an unsigned int rather than an > int, because the intention of the DT binding is that all out of range > values for a 16-bit register will cause the defaults to be used, > however, if gpio_defaults is an int then values that are larger than > INT_MAX will become negative numbers and be written out directly to the > hardware. As no where in the code replies on gpio_defaults being an int, > the simplest fix is to just change it to unsigned. > > Signed-off-by: Charles Keepax > --- > include/linux/mfd/arizona/pdata.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. > diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h > index 48fe313..1789cb0 100644 > --- a/include/linux/mfd/arizona/pdata.h > +++ b/include/linux/mfd/arizona/pdata.h > @@ -94,7 +94,7 @@ struct arizona_pdata { > int gpio_base; > > /** Pin state for GPIO pins */ > - int gpio_defaults[ARIZONA_MAX_GPIO]; > + unsigned int gpio_defaults[ARIZONA_MAX_GPIO]; > > /** > * Maximum number of channels clocks will be generated for, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog