From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbbC3HPs (ORCPT ); Mon, 30 Mar 2015 03:15:48 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38819 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbbC3HPq (ORCPT ); Mon, 30 Mar 2015 03:15:46 -0400 Date: Mon, 30 Mar 2015 08:15:41 +0100 From: Lee Jones To: Aaro Koskinen Cc: Samuel Ortiz , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , Felipe Balbi Subject: Re: [PATCH 3/3] mfd: menelaus: use macro for magic number Message-ID: <20150330071541.GJ457@x1> References: <1427575537-28508-1-git-send-email-aaro.koskinen@iki.fi> <1427575537-28508-4-git-send-email-aaro.koskinen@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1427575537-28508-4-git-send-email-aaro.koskinen@iki.fi> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 28 Mar 2015, Aaro Koskinen wrote: > Use macro to check a register bit. > > Signed-off-by: Aaro Koskinen > --- > drivers/mfd/menelaus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c > index 917fa86..c2ca665 100644 > --- a/drivers/mfd/menelaus.c > +++ b/drivers/mfd/menelaus.c > @@ -1216,7 +1216,7 @@ static int menelaus_probe(struct i2c_client *client, > err = menelaus_read_reg(MENELAUS_VCORE_CTRL1); > if (err < 0) > goto fail; > - if (err & BIT(7)) > + if (err & VCORE_CTRL1_HW_NSW) > menelaus->vcore_hw_mode = 1; > else > menelaus->vcore_hw_mode = 0; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog