From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753029AbbC3Iuj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 04:50:39 -0400
Received: from mail-wi0-f180.google.com ([209.85.212.180]:38547 "EHLO
	mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752800AbbC3Iuf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 04:50:35 -0400
Date: Mon, 30 Mar 2015 09:50:30 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Holger Dengler <dengler@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Peter Mahler <mahler@xkrug.com>,
        Juergen Bubeck <bubeck@xkrug.com>,
        Benedikt Spranger <b.spranger@linutronix.de>,
        Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 06/11] mfd: flexcard: add DMA interrupt domain
Message-ID: <20150330085030.GQ457@x1>
References: <1427277120-16924-1-git-send-email-dengler@linutronix.de>
 <1427277120-16924-7-git-send-email-dengler@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1427277120-16924-7-git-send-email-dengler@linutronix.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 25 Mar 2015, Holger Dengler wrote:

> From: Benedikt Spranger <b.spranger@linutronix.de>
> 
> The Flexcard comprise an interrupt controller for the attached
> tinys, timer, a Flexray related trigger and a second one for DMA.
> Both controllers share a single IRQ line.
> 
> Add an interrupt domain for the DMA Controller interrupts.
> 
> Signed-off-by: Holger Dengler <dengler@linutronix.de>
> Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
> cc: Samuel Ortiz <sameo@linux.intel.com>
> cc: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/flexcard/irq.c   | 95 +++++++++++++++++++++++++++++++++++++++++---
>  drivers/mfd/flexcard/irq.h   | 11 +++++
>  include/linux/mfd/flexcard.h | 23 +++++++++++
>  3 files changed, 124 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mfd/flexcard/irq.c b/drivers/mfd/flexcard/irq.c
> index fefcb24..17e8b2c 100644
> --- a/drivers/mfd/flexcard/irq.c
> +++ b/drivers/mfd/flexcard/irq.c
> @@ -27,11 +27,13 @@
>  static irqreturn_t flexcard_demux(int irq, void *data)
>  {
>  	struct flexcard_device *priv = data;
> -	u32 stat;
> +	u32 stat, dma_stat;
>  	int i, cur;
>  
>  	stat = readl(&priv->conf->irs);
> -	if (!stat)
> +	dma_stat = readl(&priv->conf->dma_irsr);
> +
> +	if (!stat && !dma_stat)
>  		return IRQ_NONE;
>  
>  	for (i = 0; i < NR_FLEXCARD_IRQ; i++) {
> @@ -41,6 +43,15 @@ static irqreturn_t flexcard_demux(int irq, void *data)
>  				generic_handle_irq(cur);
>  		}
>  	}
> +
> +	for (i = 0; i < NR_FLEXCARD_DMA_IRQ; i++) {
> +		if (dma_stat & flexcard_dma_irq_tab[i].status) {
> +			cur = irq_find_mapping(priv->dma_domain, i);
> +			if (cur)
> +				generic_handle_irq(cur);
> +		}
> +	}

You might only want to do the top if (stat) and only the second if
(dma_stat).

[...]

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog