From: Jiri Olsa <jolsa@redhat.com>
To: David Hildenbrand <dahi@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
paulus@samba.org, mingo@redhat.com, acme@kernel.org,
acme@redhat.com, jolsa@kernel.org, kan.liang@intel.com,
namhyung@kernel.org, adrian.hunter@intel.com, ak@linux.intel.com,
brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com
Subject: Re: [PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode
Date: Mon, 30 Mar 2015 10:54:34 +0200 [thread overview]
Message-ID: <20150330085434.GA12734@krava.brq.redhat.com> (raw)
In-Reply-To: <1427703060-59883-1-git-send-email-dahi@linux.vnet.ibm.com>
On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote:
> Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to
> add_callchain_ip") promised "No change in behavior.".
>
> As this commit breaks callchains on s390x (symbols not getting resolved,
I think it's a generic problem not just s390x
the x86 archs were safe due to the (al->map == NULL) fallback
in thread__find_addr_map, where we rerun the lookup for kernel
maps.. I need to rethink this check :-\
perhaps s390x did not match the machine__kernel_ip condition?
> observed when profiling the kernel), this statement is wrong. The cpumode
> must be kept when iterating over all ips, otherwise the default
> (PERF_RECORD_MISC_USER) will be used by error.
anyway
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2015-03-30 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 15:08 [PATCH v1] perf callchain: fix kernel symbol resolution by remembering the cpumode David Hildenbrand
2015-03-27 16:09 ` Liang, Kan
2015-03-27 19:12 ` David Hildenbrand
2015-03-30 8:11 ` [PATCH v2] " David Hildenbrand
2015-03-30 8:54 ` Jiri Olsa [this message]
2015-03-30 9:18 ` David Hildenbrand
2015-04-02 12:23 ` [tip:perf/core] perf callchain: Fix " tip-bot for David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330085434.GA12734@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox