[PATCH] mfd: axp20x: Fix duplicate const for model names

[PATCH] mfd: axp20x: Fix duplicate const for model names

[Krzysztof Kozlowski]

Replace duplicated const keyword for 'axp20x_model_names' with proper
array of const pointers to const strings.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 drivers/mfd/axp20x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 0acbe52b2411..1386826f713d 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -29,7 +29,7 @@
 
 #define AXP20X_OFF	0x80
 
-static const char const *axp20x_model_names[] = {
+static const char * const axp20x_model_names[] = {
 	"AXP202",
 	"AXP209",
 	"AXP288",
-- 
1.9.1

Re: [PATCH] mfd: axp20x: Fix duplicate const for model names

[Joe Perches]

On Tue, 2015-03-24 at 11:21 +0100, Krzysztof Kozlowski wrote:
> Replace duplicated const keyword for 'axp20x_model_names' with proper
> array of const pointers to const strings.

A few more of these exist:

arch/arm/mach-bcm/bcm_cygnus.c:16:static const char const *bcm_cygnus_dt_compat[] = {
drivers/clk/clk-si5351.c:71:static const char const *si5351_input_names[] = {
drivers/clk/clk-si5351.c:74:static const char const *si5351_pll_names[] = {
drivers/clk/clk-si5351.c:77:static const char const *si5351_msynth_names[] = {
drivers/clk/clk-si5351.c:80:static const char const *si5351_clkout_names[] = {
drivers/clk/clk-ls1x.c:83:static const char const *cpu_parents[] = { "cpu_clk_div", "osc_33m_clk", };
drivers/clk/clk-ls1x.c:84:static const char const *ahb_parents[] = { "ahb_clk_div", "osc_33m_clk", };
drivers/clk/clk-ls1x.c:85:static const char const *dc_parents[] = { "dc_clk_div", "osc_33m_clk", };
sound/pci/asihpi/asihpi.c:2379:static const char const *sampleclock_sources[] = {
sound/soc/sh/rcar/dvc.c:39:static const char const *dvc_ramp_rate[] = {

Re: [PATCH] mfd: axp20x: Fix duplicate const for model names

[Krzysztof Kozlowski]

2015-03-24 14:53 GMT+01:00 Joe Perches <joe@perches.com>:
> On Tue, 2015-03-24 at 11:21 +0100, Krzysztof Kozlowski wrote:
>> Replace duplicated const keyword for 'axp20x_model_names' with proper
>> array of const pointers to const strings.
>
> A few more of these exist:
>
> arch/arm/mach-bcm/bcm_cygnus.c:16:static const char const *bcm_cygnus_dt_compat[] = {
> drivers/clk/clk-si5351.c:71:static const char const *si5351_input_names[] = {
> drivers/clk/clk-si5351.c:74:static const char const *si5351_pll_names[] = {
> drivers/clk/clk-si5351.c:77:static const char const *si5351_msynth_names[] = {
> drivers/clk/clk-si5351.c:80:static const char const *si5351_clkout_names[] = {
> drivers/clk/clk-ls1x.c:83:static const char const *cpu_parents[] = { "cpu_clk_div", "osc_33m_clk", };
> drivers/clk/clk-ls1x.c:84:static const char const *ahb_parents[] = { "ahb_clk_div", "osc_33m_clk", };
> drivers/clk/clk-ls1x.c:85:static const char const *dc_parents[] = { "dc_clk_div", "osc_33m_clk", };
> sound/pci/asihpi/asihpi.c:2379:static const char const *sampleclock_sources[] = {
> sound/soc/sh/rcar/dvc.c:39:static const char const *dvc_ramp_rate[] = {

Thanks, I grepped them also :).

For the clk-si5351.c I sent a patch few weeks ago. Recently resent it:
https://lkml.org/lkml/2015/3/20/153

For the asihpi and rcard/dvc I just sent a patch few minutes ago.

The bcm_cygnus is already fixed by someone else.

The remaining clk-ls1x.c is on MIPS (MACH_LOONGSON1) which I cannot
compile now (I don't have MIPS cross-compiler). Maybe someone from
MIPS can fix it?

Best regards,
Krzysztof

Re: [PATCH] mfd: axp20x: Fix duplicate const for model names

[Lee Jones]

On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote:

> Replace duplicated const keyword for 'axp20x_model_names' with proper
> array of const pointers to const strings.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/mfd/axp20x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied thanks.

Joe, 
  Can I apply your Ack?

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 0acbe52b2411..1386826f713d 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -29,7 +29,7 @@
>  
>  #define AXP20X_OFF	0x80
>  
> -static const char const *axp20x_model_names[] = {
> +static const char * const axp20x_model_names[] = {
>  	"AXP202",
>  	"AXP209",
>  	"AXP288",

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog